-
Notifications
You must be signed in to change notification settings - Fork 4.6k
/
instancegroup.go
432 lines (357 loc) · 15.4 KB
/
instancegroup.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
/*
Copyright 2017 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package validation
import (
"fmt"
"strings"
"k8s.io/kops/pkg/nodeidentity/aws"
"github.com/aws/aws-sdk-go/aws/arn"
"github.com/aws/aws-sdk-go/service/ec2"
"k8s.io/apimachinery/pkg/util/sets"
"k8s.io/apimachinery/pkg/util/validation/field"
"k8s.io/kops/pkg/apis/kops"
"k8s.io/kops/pkg/apis/kops/util"
"k8s.io/kops/upup/pkg/fi"
"k8s.io/kops/upup/pkg/fi/cloudup/awsup"
"k8s.io/kops/upup/pkg/fi/cloudup/gce"
)
// ValidateInstanceGroup is responsible for validating the configuration of a instancegroup
func ValidateInstanceGroup(g *kops.InstanceGroup, cloud fi.Cloud, strict bool) field.ErrorList {
allErrs := field.ErrorList{}
if g.ObjectMeta.Name == "" {
allErrs = append(allErrs, field.Required(field.NewPath("objectMeta", "name"), ""))
}
switch g.Spec.Role {
case "":
allErrs = append(allErrs, field.Required(field.NewPath("spec", "role"), "Role must be set"))
case kops.InstanceGroupRoleControlPlane:
if len(g.Spec.Subnets) == 0 {
allErrs = append(allErrs, field.Required(field.NewPath("spec", "subnets"), "controlPlane InstanceGroup must specify at least one Subnet"))
}
if fi.ValueOf(g.Spec.MinSize) > 1 {
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "minSize"), fi.ValueOf(g.Spec.MinSize), "controlPlane InstanceGroup must have minSize set to 1"))
}
if fi.ValueOf(g.Spec.MaxSize) > 1 {
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "maxSize"), fi.ValueOf(g.Spec.MaxSize), "controlPlane InstanceGroup must have maxSize set to 1, add more InstanceGroups instead"))
}
case kops.InstanceGroupRoleNode:
case kops.InstanceGroupRoleBastion:
case kops.InstanceGroupRoleAPIServer:
default:
var supported []string
for _, role := range kops.AllInstanceGroupRoles {
supported = append(supported, string(role))
}
allErrs = append(allErrs, field.NotSupported(field.NewPath("spec", "role"), g.Spec.Role, supported))
}
if g.Spec.Tenancy != "" {
allErrs = append(allErrs, IsValidValue(field.NewPath("spec", "tenancy"), &g.Spec.Tenancy, ec2.Tenancy_Values())...)
}
if strict && g.Spec.Manager == kops.InstanceManagerCloudGroup {
if g.Spec.MaxSize == nil {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "maxSize"), "maxSize must be set"))
}
if g.Spec.MinSize == nil {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "minSize"), "minSize must be set"))
}
}
if g.Spec.MaxSize != nil && g.Spec.MinSize != nil {
if *g.Spec.MaxSize < *g.Spec.MinSize {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "maxSize"), "maxSize must be greater than or equal to minSize."))
}
}
if strict && g.Spec.Image == "" {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "image"), "image must be specified."))
}
if g.Spec.RootVolume != nil {
if fi.ValueOf(g.Spec.RootVolume.IOPS) < 0 {
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "rootVolume", "iops"), g.Spec.RootVolume.IOPS, "IOPS must be greater than 0"))
}
if fi.ValueOf(g.Spec.RootVolume.Throughput) < 0 {
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "rootVolume", "throughput"), g.Spec.RootVolume.Throughput, "Throughput must be greater than 0"))
}
}
// @check all the hooks are valid in this instancegroup
for i := range g.Spec.Hooks {
allErrs = append(allErrs, validateHookSpec(&g.Spec.Hooks[i], field.NewPath("spec", "hooks").Index(i))...)
}
// @check the fileAssets for this instancegroup are valid
for i := range g.Spec.FileAssets {
allErrs = append(allErrs, validateFileAssetSpec(&g.Spec.FileAssets[i], field.NewPath("spec", "fileAssets").Index(i))...)
}
for _, UserDataInfo := range g.Spec.AdditionalUserData {
allErrs = append(allErrs, validateExtraUserData(&UserDataInfo)...)
}
// @step: iterate and check the volume specs
for i, x := range g.Spec.Volumes {
devices := make(map[string]bool)
path := field.NewPath("spec", "volumes").Index(i)
allErrs = append(allErrs, validateVolumeSpec(path, x)...)
// @check the device name has not been used already
if _, found := devices[x.Device]; found {
allErrs = append(allErrs, field.Duplicate(path.Child("device"), x.Device))
}
devices[x.Device] = true
}
// @step: iterate and check the volume mount specs
for i, x := range g.Spec.VolumeMounts {
used := make(map[string]bool)
path := field.NewPath("spec", "volumeMounts").Index(i)
allErrs = append(allErrs, validateVolumeMountSpec(path, x)...)
if _, found := used[x.Device]; found {
allErrs = append(allErrs, field.Duplicate(path.Child("device"), x.Device))
}
if _, found := used[x.Path]; found {
allErrs = append(allErrs, field.Duplicate(path.Child("path"), x.Path))
}
}
allErrs = append(allErrs, validateInstanceProfile(g.Spec.IAM, field.NewPath("spec", "iam"))...)
if g.Spec.RollingUpdate != nil {
allErrs = append(allErrs, validateRollingUpdate(g.Spec.RollingUpdate, field.NewPath("spec", "rollingUpdate"), g.Spec.Role == kops.InstanceGroupRoleControlPlane)...)
}
if g.Spec.NodeLabels != nil {
allErrs = append(allErrs, validateNodeLabels(g.Spec.NodeLabels, field.NewPath("spec", "nodeLabels"))...)
}
if g.Spec.CloudLabels != nil {
allErrs = append(allErrs, validateIGCloudLabels(g, field.NewPath("spec", "cloudLabels"))...)
}
if cloud != nil {
switch cloud.ProviderID() {
case kops.CloudProviderAWS:
allErrs = append(allErrs, awsValidateInstanceGroup(g, cloud.(awsup.AWSCloud))...)
case kops.CloudProviderGCE:
allErrs = append(allErrs, gceValidateInstanceGroup(g, cloud.(gce.GCECloud))...)
}
}
for i, lb := range g.Spec.ExternalLoadBalancers {
path := field.NewPath("spec", "externalLoadBalancers").Index(i)
allErrs = append(allErrs, validateExternalLoadBalancer(&lb, path)...)
}
allErrs = append(allErrs, IsValidValue(field.NewPath("spec", "updatePolicy"), g.Spec.UpdatePolicy, []string{kops.UpdatePolicyAutomatic, kops.UpdatePolicyExternal})...)
taintKeys := sets.NewString()
for i, taint := range g.Spec.Taints {
path := field.NewPath("spec", "taints").Index(i)
_, err := util.ParseTaint(taint)
if err != nil {
allErrs = append(allErrs, field.Invalid(path, taint, "invalid taint value"))
}
if taintKeys.Has(taint) {
allErrs = append(allErrs, field.Duplicate(path, taint))
} else {
taintKeys.Insert(taint)
}
}
return allErrs
}
// validateVolumeSpec is responsible for checking a volume spec is ok
func validateVolumeSpec(path *field.Path, v kops.VolumeSpec) field.ErrorList {
allErrs := field.ErrorList{}
if v.Device == "" {
allErrs = append(allErrs, field.Required(path.Child("device"), "device name required"))
}
if v.Size <= 0 {
allErrs = append(allErrs, field.Invalid(path.Child("size"), v.Size, "must be greater than zero"))
}
return allErrs
}
// validateVolumeMountSpec is responsible for checking the volume mount is ok
func validateVolumeMountSpec(path *field.Path, spec kops.VolumeMountSpec) field.ErrorList {
allErrs := field.ErrorList{}
if spec.Device == "" {
allErrs = append(allErrs, field.Required(path.Child("device"), "device name required"))
}
if spec.Filesystem == "" {
allErrs = append(allErrs, field.Required(path.Child("filesystem"), "filesystem type required"))
}
if spec.Path == "" {
allErrs = append(allErrs, field.Required(path.Child("path"), "mount path required"))
}
allErrs = append(allErrs, IsValidValue(path.Child("filesystem"), &spec.Filesystem, kops.SupportedFilesystems)...)
return allErrs
}
// CrossValidateInstanceGroup performs validation of the instance group, including that it is consistent with the Cluster
// It calls ValidateInstanceGroup, so all that validation is included.
func CrossValidateInstanceGroup(g *kops.InstanceGroup, cluster *kops.Cluster, cloud fi.Cloud, strict bool) field.ErrorList {
allErrs := ValidateInstanceGroup(g, cloud, strict)
if g.Spec.Role == kops.InstanceGroupRoleControlPlane {
allErrs = append(allErrs, ValidateControlPlaneInstanceGroup(g, cluster)...)
}
if g.Spec.Role == kops.InstanceGroupRoleAPIServer {
if cluster.Spec.GetCloudProvider() != kops.CloudProviderAWS {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "role"), "APIServer role only supported on AWS"))
}
if cluster.UsesNoneDNS() {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "role"), "APIServer cannot be used with topology.dns.type=None"))
}
}
// Check that instance groups are defined in subnets that are defined in the cluster
{
clusterSubnets := make(map[string]*kops.ClusterSubnetSpec)
for i := range cluster.Spec.Networking.Subnets {
s := &cluster.Spec.Networking.Subnets[i]
clusterSubnets[s.Name] = s
}
for i, z := range g.Spec.Subnets {
if clusterSubnets[z] == nil {
allErrs = append(allErrs, field.NotFound(field.NewPath("spec", "networking", "subnets").Index(i), z))
}
}
}
if cluster.Spec.GetCloudProvider() == kops.CloudProviderAWS {
if g.Spec.RootVolume != nil && g.Spec.RootVolume.Type != nil {
allErrs = append(allErrs, IsValidValue(field.NewPath("spec", "rootVolume", "type"), g.Spec.RootVolume.Type, []string{"standard", "gp3", "gp2", "io1", "io2"})...)
}
warmPool := cluster.Spec.CloudProvider.AWS.WarmPool.ResolveDefaults(g)
if warmPool.MaxSize == nil || *warmPool.MaxSize != 0 {
if g.Spec.Role != kops.InstanceGroupRoleNode && g.Spec.Role != kops.InstanceGroupRoleAPIServer {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "warmPool"), "warm pool only allowed on instance groups with role Node or APIServer"))
}
if g.Spec.MixedInstancesPolicy != nil {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "warmPool"), "warm pool cannot be combined with a mixed instances policy"))
}
if g.Spec.MaxPrice != nil {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "warmPool"), "warm pool cannot be used with spot instances"))
}
}
if warmPool.MaxSize != nil {
if *warmPool.MaxSize < 0 {
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "warmPool", "maxSize"), *warmPool.MaxSize, "warm pool maxSize cannot be negative"))
} else if warmPool.MinSize > *warmPool.MaxSize {
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "warmPool", "maxSize"), *warmPool.MaxSize, "warm pool maxSize cannot be set to lower than minSize"))
}
}
if warmPool.MinSize < 0 {
allErrs = append(allErrs, field.Invalid(field.NewPath("spec", "warmPool", "minSize"), warmPool.MinSize, "warm pool minSize cannot be negative"))
}
}
if g.Spec.Containerd != nil {
allErrs = append(allErrs, validateContainerdConfig(&cluster.Spec, g.Spec.Containerd, field.NewPath("spec", "containerd"), false)...)
}
return allErrs
}
func ValidateControlPlaneInstanceGroup(g *kops.InstanceGroup, cluster *kops.Cluster) field.ErrorList {
allErrs := field.ErrorList{}
for _, etcd := range cluster.Spec.EtcdClusters {
hasEtcd := false
for _, m := range etcd.Members {
if fi.ValueOf(m.InstanceGroup) == g.ObjectMeta.Name {
hasEtcd = true
break
}
}
if !hasEtcd {
allErrs = append(allErrs, field.Forbidden(field.NewPath("spec", "metadata", "name"), fmt.Sprintf("InstanceGroup \"%s\" with role ControlPlane must have a member in etcd cluster \"%s\"", g.ObjectMeta.Name, etcd.Name)))
}
}
return allErrs
}
var validUserDataTypes = []string{
"text/x-include-once-url",
"text/x-include-url",
"text/cloud-config-archive",
"text/upstart-job",
"text/cloud-config",
"text/part-handler",
"text/x-shellscript",
"text/cloud-boothook",
}
func validateExtraUserData(userData *kops.UserData) field.ErrorList {
allErrs := field.ErrorList{}
fieldPath := field.NewPath("additionalUserData")
if userData.Name == "" {
allErrs = append(allErrs, field.Required(fieldPath.Child("name"), "field must be set"))
}
if userData.Content == "" {
allErrs = append(allErrs, field.Required(fieldPath.Child("content"), "field must be set"))
}
allErrs = append(allErrs, IsValidValue(fieldPath.Child("type"), &userData.Type, validUserDataTypes)...)
return allErrs
}
// validateInstanceProfile checks the String values for the AuthProfile
func validateInstanceProfile(v *kops.IAMProfileSpec, fldPath *field.Path) field.ErrorList {
allErrs := field.ErrorList{}
if v != nil && v.Profile != nil {
instanceProfileARN := *v.Profile
parsedARN, err := arn.Parse(instanceProfileARN)
if err != nil || !strings.HasPrefix(parsedARN.Resource, "instance-profile/") {
allErrs = append(allErrs, field.Invalid(fldPath.Child("profile"), instanceProfileARN,
"Instance Group IAM Instance Profile must be a valid aws arn such as arn:aws:iam::123456789012:instance-profile/KopsExampleRole"))
}
}
return allErrs
}
func validateNodeLabels(labels map[string]string, fldPath *field.Path) (allErrs field.ErrorList) {
for key := range labels {
if strings.Count(key, "/") > 1 {
allErrs = append(allErrs, field.Invalid(fldPath, key, "Node label may only contain a single slash"))
}
}
return allErrs
}
func validateIGCloudLabels(ig *kops.InstanceGroup, fldPath *field.Path) (allErrs field.ErrorList) {
labels := ig.Spec.CloudLabels
if labels == nil {
return allErrs
}
genericLabels := make(map[string]string)
for key, value := range labels {
if key == aws.CloudTagInstanceGroupName {
if value != ig.ObjectMeta.Name {
allErrs = append(allErrs, field.Invalid(fldPath.Child(aws.CloudTagInstanceGroupName), key, "value must match instance group name"))
}
} else {
genericLabels[key] = value
}
}
allErrs = append(allErrs, validateCloudLabels(genericLabels, fldPath)...)
return allErrs
}
func validateExternalLoadBalancer(lb *kops.LoadBalancerSpec, fldPath *field.Path) field.ErrorList {
allErrs := field.ErrorList{}
if lb.LoadBalancerName != nil && lb.TargetGroupARN != nil {
allErrs = append(allErrs, field.TooMany(fldPath, 2, 1))
}
if lb.LoadBalancerName != nil {
name := fi.ValueOf(lb.LoadBalancerName)
if len(name) > 32 {
allErrs = append(allErrs, field.Invalid(fldPath.Child("loadBalancerName"), name,
"Load Balancer name must have at most 32 characters"))
}
}
if lb.TargetGroupARN != nil {
actual := fi.ValueOf(lb.TargetGroupARN)
parsed, err := arn.Parse(actual)
if err != nil {
allErrs = append(allErrs, field.Invalid(fldPath.Child("targetGroupARN"), actual,
fmt.Sprintf("Target Group ARN must be a valid AWS ARN: %v", err)))
return allErrs
}
resource := strings.Split(parsed.Resource, "/")
if len(resource) != 3 {
allErrs = append(allErrs, field.Invalid(fldPath.Child("targetGroupARN"), actual,
"Target Group ARN resource must be a valid AWS ARN resource such as \"targetgroup/tg-name/1234567890123456\""))
return allErrs
}
kind := resource[0]
if kind != "targetgroup" {
allErrs = append(allErrs, field.Invalid(fldPath.Child("targetGroupARN"), kind,
"Target Group ARN resource type must be \"targetgroup\""))
}
name := resource[1]
if len(name) > 32 {
allErrs = append(allErrs, field.Invalid(fldPath.Child("targetGroupARN"), name,
"Target Group ARN resource name must have at most 32 characters"))
}
}
return allErrs
}