Skip to content

Commit

Permalink
Merge pull request #11879 from rifelpet/node-os-arch
Browse files Browse the repository at this point in the history
Kubetest2 - set node-os-arch flag instead of skipping kubectl test on arm64
  • Loading branch information
k8s-ci-robot committed Jun 28, 2021
2 parents 917c965 + 6f00d07 commit 0432737
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 11 deletions.
11 changes: 0 additions & 11 deletions tests/e2e/pkg/tester/skip_regex.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,17 +70,6 @@ func (t *Tester) setSkipRegexFlag() error {
}
}

igs, err := t.getKopsInstanceGroups()
if err != nil {
return err
}
for _, ig := range igs {
if strings.Contains(ig.Spec.Image, "arm64") {
skipRegex += "|Simple.pod.should.handle.in-cluster.config"
break
}
}

// Ensure it is valid regex
if _, err := regexp.Compile(skipRegex); err != nil {
return err
Expand Down
19 changes: 19 additions & 0 deletions tests/e2e/pkg/tester/tester.go
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,21 @@ func (t *Tester) getZones() ([]string, error) {
return zoneNames, nil
}

func (t *Tester) addNodeOSArchFlag() error {
igs, err := t.getKopsInstanceGroups()
if err != nil {
return err
}
for _, ig := range igs {
if strings.Contains(ig.Spec.Image, "arm64") {
klog.Info("Setting --node-os-arch=arm64")
t.TestArgs += " --node-os-arch=arm64"
break
}
}
return nil
}

func (t *Tester) execute() error {
fs, err := gpflag.Parse(t)
if err != nil {
Expand Down Expand Up @@ -355,6 +370,10 @@ func (t *Tester) execute() error {
return err
}

if err := t.addNodeOSArchFlag(); err != nil {
return err
}

return t.Test()
}

Expand Down

0 comments on commit 0432737

Please sign in to comment.