Skip to content

Commit

Permalink
Merge pull request #10826 from olemarkus/automated-cherry-pick-of-#10…
Browse files Browse the repository at this point in the history
…328-origin-release-1.19

Automated cherry pick of #10328: Don't try to detach masters
  • Loading branch information
k8s-ci-robot committed Feb 15, 2021
2 parents 6ed803e + 56829d9 commit 08d5ab9
Showing 1 changed file with 8 additions and 7 deletions.
15 changes: 8 additions & 7 deletions pkg/instancegroups/instancegroups.go
Original file line number Diff line number Diff line change
Expand Up @@ -603,13 +603,14 @@ func (c *RollingUpdateCluster) UpdateSingleInstance(cloudMember *cloudinstances.
if cloudMember.CloudInstanceGroup.InstanceGroup.IsMaster() {
klog.Warning("cannot detach master instances. Assuming --surge=false")

}
err := c.detachInstance(cloudMember)
if err != nil {
return fmt.Errorf("failed to detach instance: %v", err)
}
if err := c.maybeValidate(" after detaching instance", c.ValidateCount); err != nil {
return err
} else {
err := c.detachInstance(cloudMember)
if err != nil {
return fmt.Errorf("failed to detach instance: %v", err)
}
if err := c.maybeValidate(" after detaching instance", c.ValidateCount); err != nil {
return err
}
}
}

Expand Down

0 comments on commit 08d5ab9

Please sign in to comment.