Skip to content

Commit

Permalink
Merge pull request #7341 from justinsb/etcd_default_3_3_10
Browse files Browse the repository at this point in the history
Default etcd-version to 3.3.10 for >= 1.14
  • Loading branch information
k8s-ci-robot committed Jul 30, 2019
2 parents 9478909 + 1795d25 commit 5cfd1a0
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions pkg/model/components/etcd.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ const (
DefaultEtcd3Version_1_11 = "3.2.24"

DefaultEtcd3Version_1_13 = "3.2.24"

DefaultEtcd3Version_1_14 = "3.3.10"
)

// BuildOptions is responsible for filling in the defaults for the etcd cluster model
Expand All @@ -60,7 +62,9 @@ func (b *EtcdOptionsBuilder) BuildOptions(o interface{}) error {
// Ensure the version is set
if c.Version == "" && c.Provider == kops.EtcdProviderTypeLegacy {
// Even if in legacy mode, etcd version 2 is unsupported as of k8s 1.13
if b.IsKubernetesGTE("1.13") {
if b.IsKubernetesGTE("1.14") {
c.Version = DefaultEtcd3Version_1_14
} else if b.IsKubernetesGTE("1.13") {
c.Version = DefaultEtcd3Version_1_13
} else {
c.Version = DefaultEtcd2Version
Expand All @@ -69,7 +73,11 @@ func (b *EtcdOptionsBuilder) BuildOptions(o interface{}) error {

if c.Version == "" && c.Provider == kops.EtcdProviderTypeManager {
// From 1.11, we run the k8s-recommended versions of etcd when using the manager
if b.IsKubernetesGTE("1.11") {
if b.IsKubernetesGTE("1.14") {
c.Version = DefaultEtcd3Version_1_14
} else if b.IsKubernetesGTE("1.13") {
c.Version = DefaultEtcd3Version_1_13
} else if b.IsKubernetesGTE("1.11") {
c.Version = DefaultEtcd3Version_1_11
} else {
c.Version = DefaultEtcd2Version
Expand Down

0 comments on commit 5cfd1a0

Please sign in to comment.