Skip to content

Commit

Permalink
go-bindata: don't store file metadata
Browse files Browse the repository at this point in the history
This was a big contributor to the build being non-repeatable.
  • Loading branch information
justinsb committed Feb 15, 2020
1 parent fcd75d5 commit 80f0690
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ kops-gobindata: gobindata-tool ${BINDATA_TARGETS}

UPUP_MODELS_BINDATA_SOURCES:=$(shell find upup/models/ | egrep -v "upup/models/bindata.go")
upup/models/bindata.go: ${GOBINDATA} ${UPUP_MODELS_BINDATA_SOURCES}
cd ${GOPATH_1ST}/src/k8s.io/kops; ${GOBINDATA} -o $@ -pkg models -ignore="\\.DS_Store" -ignore="bindata\\.go" -ignore="vfs\\.go" -prefix upup/models/ upup/models/... && GO111MODULE=on go run golang.org/x/tools/cmd/goimports -w -v upup/models/bindata.go
cd ${GOPATH_1ST}/src/k8s.io/kops; ${GOBINDATA} -o $@ -pkg models -nometadata -ignore="\\.DS_Store" -ignore="bindata\\.go" -ignore="vfs\\.go" -prefix upup/models/ upup/models/... && GO111MODULE=on go run golang.org/x/tools/cmd/goimports -w -v upup/models/bindata.go

# Build in a docker container with golang 1.X
# Used to test we have not broken 1.X
Expand Down
1 change: 1 addition & 0 deletions upup/models/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ genrule(
cmd = """
$(location //vendor/github.com/go-bindata/go-bindata/go-bindata:go-bindata) \
-o "$(OUTS)" -pkg models \
-nometadata \
-prefix $$(pwd) \
-prefix upup/models $(SRCS)
""",
Expand Down

0 comments on commit 80f0690

Please sign in to comment.