Skip to content

Commit

Permalink
Fix some broken development docs links
Browse files Browse the repository at this point in the history
  • Loading branch information
gjtempleton committed Dec 10, 2019
1 parent 11cec04 commit a8e5148
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 16 deletions.
2 changes: 1 addition & 1 deletion docs/development/rolling_update.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,6 @@ Upgrading and modifying a k8s cluster often requires the replacement of nodes.

When starting the rolling update, kops will check each instance in the instance group if it needs to be updated, so when you just update nodes, the master will not be updated. When your rolling update is interrupted and you run another rolling update, instances that have been updated before will not be updated again.

![Rolling Update Diagram](/docs/development/images/rolling-update.png?raw=true "Rolling Updates Diagram")
![Rolling Update Diagram](/development/images/rolling-update.png?raw=true "Rolling Updates Diagram")

`kops` executes steps 2-4 for all the masters until the masters are replaced. Then the same process is followed to replaces all nodes.
31 changes: 16 additions & 15 deletions docs/welcome/contributing.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Are you interested in contributing to kops? We, the maintainers and community,
would love your suggestions, contributions, and help! We have a quick-start
guide on [adding a feature](/docs/development/adding_a_feature.md). Also, the
guide on [adding a feature](../development/adding_a_feature.md). Also, the
maintainers can be contacted at any time to learn more about how to get
involved.

Expand All @@ -19,18 +19,19 @@ that the only people who can get things done around here are the "maintainers".
We also would love to add more "official" maintainers, so show us what you can
do!


What this means:

__Issues__

* Help read and triage issues, assist when possible.
* Point out issues that are duplicates, out of date, etc.
- Even if you don't have tagging permissions, make a note and tag maintainers (`/close`,`/dupe #127`).
* Even if you don't have tagging permissions, make a note and tag maintainers (`/close`,`/dupe #127`).

__Pull Requests__

* Read and review the code. Leave comments, questions, and critiques (`/lgtm` ).
* Download, compile, and run the code and make sure the tests pass (make test).
- Also verify that the new feature seems sane, follows best architectural patterns, and includes tests.
* Also verify that the new feature seems sane, follows best architectural patterns, and includes tests.

This repository uses the Kubernetes bots. See a full list of the commands [here](
https://go.k8s.io/bot-commands).
Expand All @@ -53,20 +54,20 @@ Please check in with us in the [#kops-users](https://kubernetes.slack.com/messag

If you think you have found a bug please follow the instructions below.

- Please spend a small amount of time giving due diligence to the issue tracker. Your issue might be a duplicate.
- Set `-v 10` command line option and save the log output. Please paste this into your issue.
- Note the version of kops you are running (from `kops version`), and the command line options you are using.
- Open a [new issue](https://github.com/kubernetes/kops/issues/new).
- Remember users might be searching for your issue in the future, so please give it a meaningful title to helps others.
- Feel free to reach out to the kops community on [kubernetes slack](https://github.com/kubernetes/community/blob/master/communication.md#social-media).
* Please spend a small amount of time giving due diligence to the issue tracker. Your issue might be a duplicate.
* Set `-v 10` command line option and save the log output. Please paste this into your issue.
* Note the version of kops you are running (from `kops version`), and the command line options you are using.
* Open a [new issue](https://github.com/kubernetes/kops/issues/new).
* Remember users might be searching for your issue in the future, so please give it a meaningful title to helps others.
* Feel free to reach out to the kops community on [kubernetes slack](https://github.com/kubernetes/community/blob/master/communication.md#social-media).


### Features

We also use the issue tracker to track features. If you have an idea for a feature, or think you can help kops become even more awesome follow the steps below.

- Open a [new issue](https://github.com/kubernetes/kops/issues/new).
- Remember users might be searching for your issue in the future, so please give it a meaningful title to helps others.
- Clearly define the use case, using concrete examples. EG: I type `this` and kops does `that`.
- Some of our larger features will require some design. If you would like to include a technical design for your feature please include it in the issue.
- After the new feature is well understood, and the design agreed upon we can start coding the feature. We would love for you to code it. So please open up a **WIP** *(work in progress)* pull request, and happy coding.
* Open a [new issue](https://github.com/kubernetes/kops/issues/new).
* Remember users might be searching for your issue in the future, so please give it a meaningful title to helps others.
* Clearly define the use case, using concrete examples. EG: I type `this` and kops does `that`.
* Some of our larger features will require some design. If you would like to include a technical design for your feature please include it in the issue.
* After the new feature is well understood, and the design agreed upon we can start coding the feature. We would love for you to code it. So please open up a **WIP** *(work in progress)* pull request, and happy coding.

0 comments on commit a8e5148

Please sign in to comment.