Don't modify shared subnets

kubernetes · Dec 1, 2021 · ad29ed4 · ad29ed4
1 parent 1e1a148
commit ad29ed4
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/upup/pkg/fi/cloudup/awstasks/subnet.go b/upup/pkg/fi/cloudup/awstasks/subnet.go
@@ -201,15 +201,20 @@ func (s *Subnet) CheckChanges(a, e, changes *Subnet) error {
 	return nil
 }
 
-func (_ *Subnet) RenderAWS(t *awsup.AWSAPITarget, a, e, changes *Subnet) error {
+func (_ *Subnet) ShouldCreate(a, e, changes *Subnet) (bool, error) {
 	shared := fi.BoolValue(e.Shared)
 	if shared {
 		// Verify the subnet was found
 		if a == nil {
-			return fmt.Errorf("Subnet with id %q not found", fi.StringValue(e.ID))
+			return false, fmt.Errorf("subnet with id %q not found", fi.StringValue(e.ID))
 		}
+
+		return false, nil
 	}
+	return true, nil
+}
 
+func (_ *Subnet) RenderAWS(t *awsup.AWSAPITarget, a, e, changes *Subnet) error {
 	if strings.HasPrefix(aws.StringValue(e.IPv6CIDR), "/") {
 		vpcIPv6CIDR := e.VPC.IPv6CIDR
 		if vpcIPv6CIDR == nil {