Skip to content

Commit

Permalink
Merge pull request #10346 from hakman/automated-cherry-pick-of-#10345…
Browse files Browse the repository at this point in the history
…-upstream-release-1.19

Automated cherry pick of #10345: Alloq using gp3 for root volumes
  • Loading branch information
k8s-ci-robot committed Dec 2, 2020
2 parents 2c5261d + 40f9e3f commit d720d34
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/apis/kops/validation/instancegroup.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ func CrossValidateInstanceGroup(g *kops.InstanceGroup, cluster *kops.Cluster, cl
}

if g.Spec.RootVolumeType != nil && kops.CloudProviderID(cluster.Spec.CloudProvider) == kops.CloudProviderAWS {
allErrs = append(allErrs, IsValidValue(field.NewPath("spec", "rootVolumeType"), g.Spec.RootVolumeType, []string{"standard", "gp2", "io1", "io2"})...)
allErrs = append(allErrs, IsValidValue(field.NewPath("spec", "rootVolumeType"), g.Spec.RootVolumeType, []string{"standard", "gp3", "gp2", "io1", "io2"})...)
}

return allErrs
Expand Down
3 changes: 3 additions & 0 deletions pkg/apis/kops/validation/instancegroup_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,9 @@ func TestValidBootDevice(t *testing.T) {
{
volumeType: "standard",
},
{
volumeType: "gp3",
},
{
volumeType: "gp2",
},
Expand Down

0 comments on commit d720d34

Please sign in to comment.