Skip to content

Commit

Permalink
kops-server: ig short-name
Browse files Browse the repository at this point in the history
Also cleanup the shared REST subclass
  • Loading branch information
justinsb committed Oct 23, 2017
1 parent 0ece238 commit ed2dab1
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 43 deletions.
1 change: 0 additions & 1 deletion hack/.packages
Expand Up @@ -34,7 +34,6 @@ k8s.io/kops/pkg/apis/kops/validation
k8s.io/kops/pkg/apis/nodeup
k8s.io/kops/pkg/apiserver
k8s.io/kops/pkg/apiserver/cmd/server
k8s.io/kops/pkg/apiserver/registry
k8s.io/kops/pkg/apiserver/registry/cluster
k8s.io/kops/pkg/apiserver/registry/instancegroup
k8s.io/kops/pkg/assets
Expand Down
8 changes: 0 additions & 8 deletions pkg/apiserver/registry/BUILD.bazel

This file was deleted.

1 change: 0 additions & 1 deletion pkg/apiserver/registry/cluster/BUILD.bazel
Expand Up @@ -10,7 +10,6 @@ go_library(
deps = [
"//pkg/apis/kops:go_default_library",
"//pkg/apis/kops/validation:go_default_library",
"//pkg/apiserver/registry:go_default_library",
"//vendor/github.com/golang/glog:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/fields:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/labels:go_default_library",
Expand Down
9 changes: 6 additions & 3 deletions pkg/apiserver/registry/cluster/etcd.go
Expand Up @@ -21,11 +21,14 @@ import (
"k8s.io/apiserver/pkg/registry/generic"
genericregistry "k8s.io/apiserver/pkg/registry/generic/registry"
"k8s.io/kops/pkg/apis/kops"
"k8s.io/kops/pkg/apiserver/registry"
)

type REST struct {
*genericregistry.Store
}

// NewREST returns a RESTStorage object that will work against kops Clusters.
func NewREST(scheme *runtime.Scheme, optsGetter generic.RESTOptionsGetter) (*registry.REST, error) {
func NewREST(scheme *runtime.Scheme, optsGetter generic.RESTOptionsGetter) (*REST, error) {
strategy := NewStrategy(scheme)

store := &genericregistry.Store{
Expand All @@ -50,5 +53,5 @@ func NewREST(scheme *runtime.Scheme, optsGetter generic.RESTOptionsGetter) (*reg
if err := store.CompleteWithOptions(options); err != nil {
return nil, err
}
return &registry.REST{Store: store}, nil
return &REST{Store: store}, nil
}
2 changes: 1 addition & 1 deletion pkg/apiserver/registry/instancegroup/BUILD.bazel
Expand Up @@ -9,14 +9,14 @@ go_library(
visibility = ["//visibility:public"],
deps = [
"//pkg/apis/kops:go_default_library",
"//pkg/apiserver/registry:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/fields:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/labels:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/runtime:go_default_library",
"//vendor/k8s.io/apimachinery/pkg/util/validation/field:go_default_library",
"//vendor/k8s.io/apiserver/pkg/endpoints/request:go_default_library",
"//vendor/k8s.io/apiserver/pkg/registry/generic:go_default_library",
"//vendor/k8s.io/apiserver/pkg/registry/generic/registry:go_default_library",
"//vendor/k8s.io/apiserver/pkg/registry/rest:go_default_library",
"//vendor/k8s.io/apiserver/pkg/storage:go_default_library",
"//vendor/k8s.io/apiserver/pkg/storage/names:go_default_library",
],
Expand Down
18 changes: 15 additions & 3 deletions pkg/apiserver/registry/instancegroup/etcd.go
Expand Up @@ -20,12 +20,16 @@ import (
"k8s.io/apimachinery/pkg/runtime"
"k8s.io/apiserver/pkg/registry/generic"
genericregistry "k8s.io/apiserver/pkg/registry/generic/registry"
"k8s.io/apiserver/pkg/registry/rest"
"k8s.io/kops/pkg/apis/kops"
"k8s.io/kops/pkg/apiserver/registry"
)

type REST struct {
*genericregistry.Store
}

// NewREST returns a RESTStorage object that will work against kops InstanceGroups.
func NewREST(scheme *runtime.Scheme, optsGetter generic.RESTOptionsGetter) (*registry.REST, error) {
func NewREST(scheme *runtime.Scheme, optsGetter generic.RESTOptionsGetter) (*REST, error) {
strategy := NewStrategy(scheme)

store := &genericregistry.Store{
Expand All @@ -50,5 +54,13 @@ func NewREST(scheme *runtime.Scheme, optsGetter generic.RESTOptionsGetter) (*reg
if err := store.CompleteWithOptions(options); err != nil {
return nil, err
}
return &registry.REST{Store: store}, nil
return &REST{Store: store}, nil
}

// Implement ShortNamesProvider
var _ rest.ShortNamesProvider = &REST{}

// ShortNames implements the ShortNamesProvider interface. Returns a list of short names for a resource.
func (r *REST) ShortNames() []string {
return []string{"ig"}
}
26 changes: 0 additions & 26 deletions pkg/apiserver/registry/registry.go

This file was deleted.

0 comments on commit ed2dab1

Please sign in to comment.