Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow specifying dns-name separately? #12

Closed
justinsb opened this issue Jul 1, 2016 · 6 comments
Closed

Allow specifying dns-name separately? #12

justinsb opened this issue Jul 1, 2016 · 6 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. P2
Milestone
1.5.2

Comments

@justinsb
Copy link
Member

justinsb commented Jul 1, 2016

Maybe we should allow the ClusterName to be different from the DNS name. Users will likely want to specify a shorter name, for example. And this means we're less bound to DNS at the schema level.

On the flip side, it means cluster names are no longer globally unique.
@justinsb justinsb added the P2 label Jul 6, 2016
@justinsb justinsb modified the milestones: 1.3.0, 1.3.2 Aug 15, 2016
@yissachar
Copy link
Contributor

yissachar commented Sep 2, 2016 •
edited

On the flip side, it means cluster names are no longer globally unique.

Why does this matter? Or does globally here mean within the same AWS account?

@mrichmon
Copy link

mrichmon commented Sep 23, 2016 •
edited

What is the distinction between this and the "--dns-zone" argument?
There seems to be subtly different use cases assumed. Might be useful to articulate the differences.

@justinsb justinsb modified the milestones: 1.4.5, 1.5.0 Dec 28, 2016
@justinsb justinsb modified the milestones: 1.5.1, 1.5.0 Jan 17, 2017
@blakebarnett
Copy link

Seems like maybe there should be a clusterUid and things like the AWS tags should just combine $clusterUid-$clusterName. Should probably set max-length on clusterName then to be in line with AWS tag length limits.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 6, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 9, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

cloudbow pushed a commit to cloudbow/kops that referenced this issue Jun 8, 2018
Merge pull request kubernetes#12 in SAPI/slingtv-proxy-api from featu…
5beebc0 
…re/merge_dcos_nfl_ncaaf_restnew to feature/merge_dcos_nfl_ncaaf

* commit '5f79821febb5681ced2767c1f813afc639b51ea7':
  NFL Category added for REST APIs
cloudbow pushed a commit to cloudbow/kops that referenced this issue Jun 8, 2018
Merge pull request kubernetes#12 in SAPI/slingtv-sports-cloud-dev-dat…
db11aa0 
…acenter from feature/create_cluster_from_kops to develop

* commit '3ca57ad2a7a10988df5319d7a9d1ef544e5a13fc':
  Update aws command
cloudbow pushed a commit to cloudbow/kops that referenced this issue Jun 12, 2018
Merge pull request kubernetes#12 in SAPI/kops-aws-datacenter from dev…
7aa8fdd 
…elop to master

* commit '34d492a75600750958d25f954195c55a39f02be6':
  Add docker image for building other docker containers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. P2
Projects
None yet
Milestone
1.5.2
Development

No branches or pull requests
6 participants
@justinsb @mrichmon @yissachar @blakebarnett @k8s-ci-robot @fejta-bot