Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster Autoscaler AddOn Spec to pass extra argument to command line #12100

Closed
amitpd opened this issue Aug 4, 2021 · 5 comments
Closed

Cluster Autoscaler AddOn Spec to pass extra argument to command line #12100

amitpd opened this issue Aug 4, 2021 · 5 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@amitpd
Copy link
Contributor

amitpd commented Aug 4, 2021

/kind feature

1. Describe IN DETAIL the feature/behavior/change you would like to see.

Cluster Autoscaler, since v1.17.0, automatic discovery of EC2 instance types is enabled by default. To change it to static list, an additional command line flag --aws-use-static-instance-list=true need to be set as per below documentation.

https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#use-static-instance-list

2. Feel free to provide a design supporting your feature request.

An additional spec in cluster spec.clusterAutoscaler.awsUseStaticInstanceList can be added to control this additional command line flags.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 4, 2021
@amitpd amitpd changed the title Cluster Autoscaler Spec to pass extra argument to command line Cluster Autoscaler AddOn Spec to pass extra argument to command line Aug 4, 2021
@olemarkus
Copy link
Member

If you are able to contribute a PR for this, I am happy to review.

@amitpd
Copy link
Contributor Author

amitpd commented Aug 21, 2021

@olemarkus Raised below PR for this feature
#12187

@amitpd
Copy link
Contributor Author

amitpd commented Aug 22, 2021

@olemarkus What is the process to merge these changes into an active release branch, say release-1.21

@amitpd
Copy link
Contributor Author

amitpd commented Aug 22, 2021

@olemarkus What is the process to merge these changes into an active release branch, say release-1.21

I raised below PR for merging to release-1.21. Hope I followed the right process
#12190

@amitpd
Copy link
Contributor Author

amitpd commented Aug 24, 2021

KOPS v1.21.1 is released today and this feature is working with this new release.

@amitpd amitpd closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants