Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the list of skipped e2e test for Cilium #15448

Closed
aojea opened this issue May 24, 2023 · 8 comments · Fixed by #15753
Closed

Reduce the list of skipped e2e test for Cilium #15448

aojea opened this issue May 24, 2023 · 8 comments · Fixed by #15753
Assignees
Milestone

Comments

@aojea
Copy link
Member

aojea commented May 24, 2023

if networking.Cilium != nil {
// https://github.com/cilium/cilium/issues/10002
skipRegex += "|TCP.CLOSE_WAIT"
// https://github.com/cilium/cilium/issues/15361
skipRegex += "|external.IP.is.not.assigned.to.a.node"
// https://github.com/cilium/cilium/issues/14287
skipRegex += "|same.port.number.but.different.protocols|same.hostPort.but.different.hostIP.and.protocol"
// https://github.com/cilium/cilium/issues/9207
skipRegex += "|serve.endpoints.on.same.port.and.different.protocols"
// This may be fixed in Cilium 1.13 but skipping for now
skipRegex += "|Service.with.multiple.ports.specified.in.multiple.EndpointSlices"
if k8sVersion.Minor >= 22 {
// ref:
// https://github.com/kubernetes/kubernetes/issues/96717
// https://github.com/cilium/cilium/issues/5719
skipRegex += "|should.create.a.Pod.with.SCTP.HostPort"
}
// https://github.com/cilium/cilium/issues/18241
skipRegex += "|Services.should.create.endpoints.for.unready.pods"
skipRegex += "|Services.should.be.able.to.connect.to.terminating.and.unready.endpoints.if.PublishNotReadyAddresses.is.true"
} else if networking.KubeRouter != nil {
skipRegex += "|load-balancer|hairpin|affinity\\stimeout|service\\.kubernetes\\.io|CLOSE_WAIT"
skipRegex += "|EndpointSlice.should.support.a.Service.with.multiple"
} else if networking.Kubenet != nil {
skipRegex += "|Services.*affinity"
}

Some of them got fixed in
cilium/cilium#24202
cilium/cilium#24174

you can compare against the regex in cilium repo
https://github.com/cilium/cilium/pull/25258/files#diff-01b72d17856efb38bd2914aec50791eef6b9bc8238b6975d12f87b39cb24b008R214

Feel free to tag me to review the PR

@aojea
Copy link
Member Author

aojea commented May 24, 2023

/assign @justinsb @hakman

@hakman
Copy link
Member

hakman commented May 25, 2023

Thanks @aojea. I checked in #15449 and, for now, there's not much we can do with Cilium 1.12.x.

@aojea
Copy link
Member Author

aojea commented May 25, 2023

yeah, these changes are more recent

@johngmyers
Copy link
Member

Office hours: after we upgrade Cilium

@johngmyers johngmyers added this to the v1.28 milestone Jul 14, 2023
@johngmyers
Copy link
Member

Now we've upgraded to Cilium 1.13, I've submitted kubernetes/test-infra#30300 to see which skips we can remove.

We are still seeing failures for "Services should fallback to local terminating endpoints when there are no ready endpoints with externalTrafficPolicy=Local": https://testgrid.k8s.io/kops-network-plugins#kops-aws-cni-cilium-k8s-ci

@aojea
Copy link
Member Author

aojea commented Aug 8, 2023

is this aws specific or do we have any other jobs we can compare with?

cilium seems to have a lot of knobs per platform ...

@johngmyers
Copy link
Member

I'm adding a GCP variant of the test in kubernetes/test-infra#30324

@johngmyers
Copy link
Member

Filed cilium/cilium#27358

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants