Update Cilium to v1.12.10 #15449
Merged
Update Cilium to v1.12.10 #15449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
size/L
hakman
force-pushed
the
cilium_un-skip
branch
2 times, most recently
from
a732be4
to
23ab486
Compare
hakman
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/cc @aojea |
|
+1 |
rifelpet
approved these changes
May 25, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
rifelpet
reviewed
May 27, 2023
Comment on lines
-71
to
-76
| if k8sVersion.Minor >= 22 { | ||
| // ref: | ||
| // https://github.com/kubernetes/kubernetes/issues/96717 | ||
| // https://github.com/cilium/cilium/issues/5719 | ||
| skipRegex += "|should.create.a.Pod.with.SCTP.HostPort" | ||
| } |
There was a problem hiding this comment.
@hakman it looks like this still needs to be skipped for cilium-eni jobs:
https://testgrid.k8s.io/kops-grid#kops-grid-cilium-eni-u2004-k24-ko26
There was a problem hiding this comment.
SCTP went GA in 1.20 in kubernetes FEATURE STATE: Kubernetes v1.20 [stable]
, but cilium basic support seems that was added in 1.13 cilium/cilium#20033
Shimiazoulai
pushed a commit
to spotinst/kubernetes-kops
that referenced
this pull request
Jul 13, 2023
Update Cilium to v1.12.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.