Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dns=none with Terraform #16328

Open
rifelpet opened this issue Feb 8, 2024 · 3 comments
Open

Support dns=none with Terraform #16328

rifelpet opened this issue Feb 8, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@rifelpet
Copy link
Member

rifelpet commented Feb 8, 2024

/kind feature

1. Describe IN DETAIL the feature/behavior/change you would like to see.

Kops' dns=none doesn't work with terraform (example prow failure). In the terraform plan output, base64 decoding the aws_launch_template's user_data reveals:

ClusterName: e2e-e2e-kops-scenario-terraform.test-cncf-aws.k8s.io
ConfigServer:
  servers:
  - https://kops-controller.internal.e2e-e2e-kops-scenario-terraform.test-cncf-aws.k8s.io:3988/

This DNS record doesn't exist in any DNS zone with dns=none, nor does nodeup know what it should resolve to in order to add an /etc/hosts entry.

The userdata should be using the ELB's DNS name like api-e2e-e2e-kops-aws-arm6-i3jlo6-e2dab7cbf5eb0e5a.elb.eu-central-1.amazonaws.com

2. Feel free to provide a design supporting your feature request.

Implementing this is a bit tricky because the userdata needs to change only for --target=terraform - it will need to conditionally include interpolation like:

ConfigServer:
  servers:
  - https://${aws_lb.api-e2e-e2e-kops-scenario-terraform-test-cncf-aws-k8s-io.dns_name}:3988/

We should also document this limitation (and even add update cluster --target terraform validation) until it is supported.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 8, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 8, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 7, 2024
@rifelpet
Copy link
Member Author

rifelpet commented Jun 7, 2024

/remove-lifecycle rotten

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants