Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate kube-apiserver cloud provider logic out of tag builders #3253

Closed
andrewsykim opened this issue Aug 22, 2017 · 2 comments
Closed

Migrate kube-apiserver cloud provider logic out of tag builders #3253

andrewsykim opened this issue Aug 22, 2017 · 2 comments

Comments

@andrewsykim
Copy link
Member

andrewsykim commented Aug 22, 2017 •
edited
Loading

Continuing the discussion here with @justinsb.

We currently set the cloud provider using tags. e.g. here. We moved a lot of this logic out of tags and into code like this, we should do the same for the cloud provider option.
@andrewsykim andrewsykim mentioned this issue Aug 22, 2017
Merged
@chrislovecnm
Copy link
Contributor

Is this a duplicate? #3247

@andrewsykim
Copy link
Member Author

yes it is!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrislovecnm @andrewsykim