Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait after creating IamInstanceProfile #35

Closed
justinsb opened this issue Jul 5, 2016 · 1 comment
Closed

Wait after creating IamInstanceProfile #35

justinsb opened this issue Jul 5, 2016 · 1 comment
Labels
P2

Comments

@justinsb
Copy link
Member

justinsb commented Jul 5, 2016

IAM instance profile creation seems to be eventually consistent / async, so we usually get an annoying warning:

W0705 12:37:39.249095   10306 executor.go:86] error running task "launchConfiguration/nodes.redact": error creating AutoscalingLaunchConfiguration: ValidationError: Invalid IamInstanceProfile: nodes.jul5h.awsdata.com
        status code: 400, request id: e07c08e6-42ce-11e6-893f-a191f7d89793
W0705 12:37:39.250229   10306 executor.go:86] error running task "launchConfiguration/master-us-east-1b.masters.redact": error creating AutoscalingLaunchConfiguration: ValidationError: You are not authorized to perform this operation.
        status code: 400, request id: e17276d0-42ce-11e6-88b4-173f86f21f4f
I0705 12:37:39.250275   10306 executor.go:70] Tasks: 47 done / 51 total; 2 can run

The problem goes away on the next automatic retry, but it is off-putting
@justinsb justinsb added the P2 label Jul 5, 2016
justinsb added a commit to justinsb/kops that referenced this issue Jul 6, 2016
@justinsb
Wait for InstanceProfile to be readable after creation
6f49a50 
This should avoid spurious errors when creating dependent resources,
which fail if we try to create before the InstanceProfile is fully
created.

Issue kubernetes#35
@justinsb justinsb mentioned this issue Jul 6, 2016
Merged
justinsb added a commit to justinsb/kops that referenced this issue Jul 7, 2016
@justinsb
Report less-scary message when IAM instance profile is not ready yet
d1ef758 
IAM instance profile creation is very async, and this causes dependent
resources to fail.  That's fine - we have good retry logic - but we
should output a less frightening error message.

Issue kubernetes#35
@justinsb justinsb mentioned this issue Jul 7, 2016
Merged
justinsb added a commit to justinsb/kops that referenced this issue Jul 9, 2016
@justinsb
More tweaks to the IAM async creation tolerance
0a8b94e 
Issue kubernetes#35
@justinsb justinsb mentioned this issue Jul 9, 2016
Merged
@justinsb
Copy link
Member Author

justinsb commented Jul 9, 2016

The current behaviour now seems reasonable (not perfect though); we log "IAM instance profile not yet created/propagated", do our normal retries, and it doesn't look like an error message.

@justinsb justinsb closed this as completed Jul 9, 2016
cloudbow pushed a commit to cloudbow/kops that referenced this issue Jun 8, 2018
Merge pull request kubernetes#35 in SAPI/slingtv-proxy-api from featu…
ae804bd 
…re/kubernetes_leagues_nfl_ncaaf to develop

* commit '363cc76d37252d5d9715ddb80ceb944ac05594b2':
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justinsb