Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Being able to pass docker_extra_opts to nodes #42

Closed
felipejfc opened this issue Jul 5, 2016 · 11 comments
Closed

Being able to pass docker_extra_opts to nodes #42

felipejfc opened this issue Jul 5, 2016 · 11 comments

Comments

@felipejfc
Copy link
Contributor

For being able to pass --insecure-registry for example

@justinsb justinsb added P1 P0 and removed P1 labels Jul 8, 2016
@justinsb justinsb modified the milestone: 1.3.0 Jul 29, 2016
justinsb added a commit to justinsb/kops that referenced this issue Aug 8, 2016
@justinsb
Copy link
Member

You should now be able to specify InsecureRegistry, by editing your instance groups.

We can probably make this easier still, but hopefully this is a good start.

@justinsb justinsb modified the milestones: 1.3.2, 1.3.0 Aug 15, 2016
justinsb added a commit to justinsb/kops that referenced this issue Aug 16, 2016
@manuelfelipe
Copy link

hey @justinsb, only insecure-registry is supported right now ? Is there a way of change the default --bip created by docker (docker0 bridge). trying to use this internally but the default 172.17.0.0 is already in use for something else in our case.

Thanks

@justinsb justinsb modified the milestones: 1.4.5, 1.5.0 Dec 28, 2016
justinsb added a commit to justinsb/kops that referenced this issue Jan 20, 2017
@bsod90
Copy link

bsod90 commented Mar 28, 2017

Hi @justinsb
Sorry for the stupid question, but how exactly the config should look like to add the --insecure-registry flag for all worker nodes?
Let's say I did kop edit ig --name ... nodes, what next?

@anandkumarpatel
Copy link

I also have not figured out how to add this option correctly:
here is what I tried

kind: InstanceGroup
metadata:
  creationTimestamp: 2017-03-28T04:42:10Z
  labels:
    kops.k8s.io/cluster: kubernetes.runnable-gamma.com
  name: nodes
spec:
  image: kope.io/k8s-1.5-debian-jessie-amd64-hvm-ebs-2017-01-09
  machineType: m4.large
  maxSize: 2
  minSize: 2
  docker:
    insecureRegistry: "cool.registry.com"
  role: Node
  subnets:
  - us-west-2a

However the docker portion does not save. I can edit the other values like max size and instance type and the files save correctly. I am guessing I am missing the correct path.

@lsjostro
Copy link

@anandkumarpatel you need to put in the clusterSpec.
$ kops edit cluster $NAME

....
 docker:
    insecureRegistry: registry.example.com
    logDriver: json-file
....

@kamalguptad
Copy link

kamalguptad commented Jul 17, 2017

@lsjostro after doing this kops is giving this message:

A copy of your changes has been stored to "/tmp/kops-edit-2gdnyyaml"

Edit cancelled, no valid changes were saved.

@JanosLiebe
Copy link

Would it be easier just to allow definition of required flags as docker_opts?
....
docker:
docker_opts=--dns 1.2.3.4 --dns 5.6.7.8 -D -l info --insecure-registry insec.reg.com --insecure-registry insec2.reg.com
....

@iBluemind
Copy link
Contributor

iBluemind commented Oct 7, 2017

It didn't work that insecureRegistry specified by kops edit cluster or kops edit ig if a kops cluster was already created.
I removed a kops cluster and then re-created the cluster with kops edit cluster like below when the cluster isn't created yet, then it worked.

....
 docker:
    insecureRegistry: registry.example.com
    logDriver: ""
....

@chrislovecnm
Copy link
Contributor

You have to update and do a rolling update for changes to occurr.

@carlossg
Copy link
Contributor

carlossg commented Mar 22, 2018

for the record, when editing using kops edit cluster you need to explicitly set logDriver or it will not validate

  docker:
    insecureRegistry: 100.64.0.0/10
    logDriver: ""

cloudbow pushed a commit to cloudbow/kops that referenced this issue Jun 8, 2018
…codecompliance to develop

* commit 'd1a3c41721cb552921216b6a776f9e575c6af424':
  Add java doc and code compliance
@puneethpk
Copy link

for the record, when editing using kops edit cluster you need to explicitly set logDriver or it will not validate

  docker:
    insecureRegistry: 100.64.0.0/10
    logDriver: ""

That IP which you are passing is kubedns ClusterIP right?Does it allow docker to pull images within the cluster?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests