Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand kops to kOps #10077

Merged
merged 6 commits into from
Oct 30, 2020
Merged

Rebrand kops to kOps #10077

merged 6 commits into from
Oct 30, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Oct 21, 2020

This should make the purpose of the project more clear.
https://deploy-preview-10077--kubernetes-kops.netlify.app

/cc @justinsb @mikesplain
/hold for feedback

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2020
@olemarkus
Copy link
Member

This didn't immediately resonate well with me. Does this also change the pronunciation to k-ops?

@hakman
Copy link
Member Author

hakman commented Oct 21, 2020

This didn't immediately resonate well with me. Does this also change the pronunciation to k-ops?

I would say so, but not mandatory.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2020
@randomvariable
Copy link
Member

+100 on the idea

@olemarkus
Copy link
Member

After giving this some more thought, I am also 100% on-board with this.

@hakman
Copy link
Member Author

hakman commented Oct 27, 2020

Thanks @olemarkus :).
/assign @justinsb

@geojaz
Copy link
Member

geojaz commented Oct 28, 2020

@olemarkus Thanks for confirming, initially i had a similar reaction, but coming back to it, it feels like this is the right direction. +1 from me too

@geojaz
Copy link
Member

geojaz commented Oct 28, 2020

@hakman are you specifically waiting for justin's approval? after the discussion in office hours, i'm happy to do it

@hakman
Copy link
Member Author

hakman commented Oct 29, 2020

Thanks @geojaz. I think we all agree, so probably should merge and see how the users receive it.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2020
@hakman hakman force-pushed the kOps branch 3 times, most recently from 091a0e1 to 13ba157 Compare October 29, 2020 04:58
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2020
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2020
Copy link
Member

@geojaz geojaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're ready to do this one, so i'll push the button... With the understanding that we're all trying to do the best we can with the world we live in. And if and when we need to iterate on this, we will.
/lgtm
Thanks all

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: geojaz, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9885df8 into kubernetes:master Oct 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 30, 2020
@hakman hakman deleted the kOps branch October 30, 2020 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants