Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cilium template by specifying boolean as a string for enable-metrics #10094

Merged
merged 1 commit into from
Oct 24, 2020

Conversation

h3poteto
Copy link
Contributor

@h3poteto h3poteto commented Oct 24, 2020

Fixes: #10081

Cilium ConfigMap template was wrong, so I fixed it.
I confirmed that kops can successfully create clusters using this change when enablePrometheusMetrics is specified for Cilium.

@k8s-ci-robot
Copy link
Contributor

Hi @h3poteto. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 24, 2020
@olemarkus
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2020
@olemarkus
Copy link
Member

You can add
Fixes #10081
to your initial comment to properly link and auto-close the issue upon merge.

@olemarkus
Copy link
Member

Thanks for catching this. Could now replicate and confirm the bug. I changed the config on an already-working cluster, which is why I couldn't reproduce earlier.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2020
@hakman
Copy link
Member

hakman commented Oct 24, 2020

Thanks @h3poteto .
@olemarkus Could you cherry-pick this?
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: h3poteto, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9283f4c into kubernetes:master Oct 24, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 24, 2020
@h3poteto
Copy link
Contributor Author

Thank you for reviewing.

k8s-ci-robot added a commit that referenced this pull request Oct 24, 2020
…094-origin-release-1.19

Automated cherry pick of #10094: Fix cilium template by specifying boolean as a string for
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster not validated when cilium.enablePrometheusMetrics is set to true
4 participants