-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix cilium template by specifying boolean as a string for enable-metrics #10094
Conversation
Hi @h3poteto. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
You can add |
Thanks for catching this. Could now replicate and confirm the bug. I changed the config on an already-working cluster, which is why I couldn't reproduce earlier. /lgtm |
Thanks @h3poteto . |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: h3poteto, hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for reviewing. |
…094-origin-release-1.19 Automated cherry pick of #10094: Fix cilium template by specifying boolean as a string for
Fixes: #10081
Cilium ConfigMap template was wrong, so I fixed it.
I confirmed that kops can successfully create clusters using this change when
enablePrometheusMetrics
is specified for Cilium.