Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #9575: Rename NodeReconciler to LegacyNodeReconciler #10100

Conversation

johngmyers
Copy link
Member

Cherry pick of #9575 on release-1.19.

#9575: Rename NodeReconciler to LegacyNodeReconciler

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Oct 25, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Oct 25, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/kops-controller area/provider/openstack Issues or PRs related to openstack provider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 25, 2020
@johngmyers
Copy link
Member Author

Cherrypicking to get the fix to use BuildNodeLabels

@hakman
Copy link
Member

hakman commented Oct 25, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit a9800bb into kubernetes:release-1.19 Oct 25, 2020
@johngmyers johngmyers deleted the automated-cherry-pick-of-#9575-upstream-release-1.19 branch October 25, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kops-controller area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants