Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add random AWS zone logic + specify build stage location #10121

Merged
merged 5 commits into from
Oct 27, 2020
Merged

Add random AWS zone logic + specify build stage location #10121

merged 5 commits into from
Oct 27, 2020

Conversation

rifelpet
Copy link
Member

This copies the AWS zone randomization from test-infra/scenarios/kubernetes_e2e.py and sets a default stage location for kops builds.

It turns out the AWS e2e jobs don't use boskos, only GCE so we can start testing this before implementing boskos support.
I'll use this PR to test the new prow job from https://github.com/kubernetes/test-infra/pull/19689/files

(opening as a new PR because github doesn't seem to let you switch from regular PR to draft PR)

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2020
@rifelpet rifelpet changed the title Add random AWS zone logic + specify build stage location WIP Add random AWS zone logic + specify build stage location Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 27, 2020
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 27, 2020
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

3 similar comments
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

1 similar comment
@rifelpet
Copy link
Member Author

/test pull-kops-e2e-kubernetes-aws-kubetest2

@rifelpet rifelpet marked this pull request as ready for review October 27, 2020 15:36
@rifelpet rifelpet changed the title WIP Add random AWS zone logic + specify build stage location Add random AWS zone logic + specify build stage location Oct 27, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 27, 2020
@hakman
Copy link
Member

hakman commented Oct 27, 2020

/test pull-kops-e2e-kubernetes-aws-kubetest2

@hakman
Copy link
Member

hakman commented Oct 27, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2020
@k8s-ci-robot
Copy link
Contributor

@rifelpet: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-e2e-kubernetes-aws-kubetest2 c8f2f8e link /test pull-kops-e2e-kubernetes-aws-kubetest2

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@k8s-ci-robot k8s-ci-robot merged commit 672b656 into kubernetes:master Oct 27, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Oct 27, 2020
@rifelpet rifelpet deleted the kubetest2-3 branch May 5, 2021 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain Awaiting requested review from mikesplain

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rifelpet @k8s-ci-robot @hakman @fejta-bot