Align AWS VPC CNI manifest with upstream #10126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/addons
approved
hakman
force-pushed
the
aws-vpc-cni-reset
branch
from
de815a8
to
b4417af
Compare
k8s-ci-robot
added
size/XL
hakman
force-pushed
the
aws-vpc-cni-reset
branch
2 times, most recently
from
2510a5d
to
df37854
Compare
added 6 commits
October 28, 2020 12:31
hakman
force-pushed
the
aws-vpc-cni-reset
branch
from
df37854
to
112221e
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Thanks for the review @MoShitrit |
k8s-ci-robot
added a commit
that referenced
this pull request
Oct 28, 2020
…126-origin-release-1.19 Automated cherry pick of #10126: Align AWS VPC CNI manifest with upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1.7.x got a makeup with a lot of quoting (which is quite annoying) which makes it hard to compare to the upstream manifest.
This PR mostly adds quotes, reshuffles things and makes some minor changes to align the kOps manifest with the one from upstream:
https://raw.githubusercontent.com/aws/amazon-vpc-cni-k8s/release-1.7/config/v1.7/aws-k8s-cni.yaml
Changes are best viewed in the generated test file diff
upup/pkg/fi/cloudup/tests/bootstrapchannelbuilder/amazonvpc/networking.amazon-vpc-routed-eni-k8s-1.16.yaml./cc @MoShitrit @rifelpet