Fix output for CF and TF #10164
Merged
Fix output for CF and TF #10164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hakman The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/provider/aws
rifelpet
reviewed
Nov 4, 2020
| @@ -115,7 +114,19 @@ func (e *IAMRolePolicy) Find(c *fi.Context) (*IAMRolePolicy, error) { | |||
| if err != nil { | |||
| return nil, fmt.Errorf("error parsing PolicyDocument for IAMRolePolicy %q: %v", aws.StringValue(e.Name), err) | |||
| } | |||
| actual.PolicyDocument = fi.WrapResource(fi.NewStringResource(policy)) | |||
|
|
|||
| // Reformat the PolicyDocument by unmarshaling and re-marshaling to JSON. | |||
There was a problem hiding this comment.
The document is just a JSON that is stored in AWS. In Direct and TF case, what you send is what you get back.
In the case of CloudFormation.... you get back a nice "optimised" JSON, that is no longer matching what was sent. Obviously, kops update cluster sees this as a change and tries to fix it.
|
/test pull-kops-bazel-test |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 5, 2020
…-upstream-release-1.19 Automated cherry pick of #10164: Add missing resource names for CF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a few issues that makes
update clustershow that there are unapplied changes: