OpenStack Reset deviceID status if needed #10178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This looks good. Thanks! /lgtm |
k8s-ci-robot
added
the
lgtm
This was referenced Nov 6, 2020
k8s-ci-robot
added a commit
that referenced
this pull request
Nov 6, 2020
…-origin-release-1.19 Automated cherry pick of #10178: Reset deviceID status if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we changed the behaviour how kops rolling update works, we are all the time randomly seeing following error:
The problem here is that we delete the instance that used port x, and then we are creating new instance using port x. Seems that this behaviour is now too fast at least for our OpenStack. Still after one hour the port is attached to deleted instance. This seems OpenStack bug, but because its quite easy to fix in kops side - I will do it.
With this code we are able to run rolling updates also in these cases.
/cc @olemarkus