-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compare KubernetesAPIAccess to OpenStack allowedCIDRs deterministically #10186
Compare KubernetesAPIAccess to OpenStack allowedCIDRs deterministically #10186
Conversation
Welcome @havulv! |
Hi @havulv. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
185f07d
to
281e614
Compare
/ok-to-test |
Thanks @havulv |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: havulv, johngmyers The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This fixes #10173 by sorting the Allowed CIDRs and KubernetesAPIAccess, which will result in tasks comparing deterministic slices.
The issue in question mentions comparing the unordered contents against each other, but the change required for that might be considerable.
kops/upup/pkg/fi/changes.go
Line 181 in 3941bd5