Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto scaling group changes when using spot instances #10187

Merged
merged 1 commit into from
Nov 8, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Nov 7, 2020

Fixes: #10082
Fixes: #10104

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2020
@hakman
Copy link
Member Author

hakman commented Nov 7, 2020

/cc @rifelpet

@rifelpet
Copy link
Member

rifelpet commented Nov 8, 2020

this will be good to get in the next 1.19 prerelease
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2020
@k8s-ci-robot k8s-ci-robot merged commit af5cd1a into kubernetes:master Nov 8, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 8, 2020
@hakman hakman deleted the fix-spot-instances branch November 8, 2020 06:12
k8s-ci-robot added a commit that referenced this pull request Nov 9, 2020
…10198-upstream-release-1.19

Automated cherry pick of #10187: Fix auto scaling group changes when using spot instances #10198: Fix mismatch between expected launch template Name and ID
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
3 participants