Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use consistent naming for the remaining SGRs part two #10188

Merged
merged 1 commit into from
Jan 14, 2021
Merged

Use consistent naming for the remaining SGRs part two #10188

merged 1 commit into from
Jan 14, 2021

Conversation

olemarkus
Copy link
Member

Continuation of #10179

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/provider/aws Issues or PRs related to aws provider labels Nov 7, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 7, 2020
rdrgmnzs
rdrgmnzs reviewed Nov 11, 2020
View reviewed changes
pkg/model/firewall.go
@@ -441,6 +441,6 @@ func generateName(o *awstasks.SecurityGroupRule) string {
src = fi.StringValue(o.SecurityGroup.Name)
}

return fmt.Sprintf("%s-%s-%s-%dto%d-%s", src, direction,
return fmt.Sprintf("from-%s-%s-%s-%dto%d-%s", src, direction,
Copy link
Contributor

@rdrgmnzs rdrgmnzs Nov 11, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olemarkus please correct me if I'm wrong, but won't changing the existing resource name for the terraform resources cause all resources to be re-created, effectively causing downtime while the changes are applied to existing clusters?

cc: @rifelpet

@olemarkus
Copy link
Member Author

Yeah, I think so. I mentioned that concern and @rifelpet commented here:
#10179 (comment)

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 23, 2020
@olemarkus olemarkus mentioned this pull request Dec 30, 2020
Merged
@olemarkus
Copy link
Member Author

/cc @justinsb

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 14, 2021
@hakman
Copy link
Member

hakman commented Jan 14, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 14, 2021
@hakman
Copy link
Member

hakman commented Jan 14, 2021

/retest

2 similar comments
@olemarkus
Copy link
Member Author

/retest

@olemarkus
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 00a92c1 into kubernetes:master Jan 14, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdrgmnzs rdrgmnzs rdrgmnzs left review comments

@johngmyers johngmyers Awaiting requested review from johngmyers

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@olemarkus @k8s-ci-robot @hakman @rdrgmnzs