-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make etcd-manager log verbosity configurable #10194
Make etcd-manager log verbosity configurable #10194
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @elblivion! |
Hi @elblivion. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0f69082
to
8e558c5
Compare
8e558c5
to
bd370bf
Compare
I signed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @elblivion thanks for the PR! Things look great, I left one comment/NIT once that's taken care of I'll go ahead and approve the PR.
pkg/apis/kops/cluster.go
Outdated
@@ -512,6 +512,9 @@ type EtcdManagerSpec struct { | |||
// This allows etcd setting to be overwriten. No config validation is done. | |||
// A list of etcd config ENV vars can be found at https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/configuration.md | |||
Env []EnvVar `json:"env,omitempty"` | |||
// LogVerbosity allows the klog library verbose log level to be set. The default is 6. | |||
// https://github.com/google/glog#verbose-logging | |||
LogVerbosity *int32 `json:"logVerbosity,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rename this to LogLevel to follow the pattern used in other components.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing - also, to avoid further confusion it might help to clarify further that this is the etcd-manager log level, not the etcd it manages; any suggestions on that? e.g. a clearer comment (which I saw is put into the CRD), but maybe also in the property name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just a comment mentioning this is for etcd-manager would be enough.
bd370bf
to
c117d8d
Compare
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elblivion, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @rdrgmnzs! Would this be accepted for cherry-picking into 1.19 beta? Or is it too late? |
…194-origin-release-1.19 Automated cherry pick of #10194: feat: Make etcd-manager log verbosity configurable
This PR addresses #7946, which I believed was closed in error - the PR referenced as a fix allows the etcd log level to be changed, but etcd-manager has its own klog-based log level which was hardcoded to a quite verbose level in Kops itself, even reducing the log level of etcd you still have to deal with a lot of noise which then has to be filtered out in fluentd or whatever you use to collect/aggregate container logs.
I took #8402 as a guide, please let me know what you think.