Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove components from cluster validation #10214

Merged
merged 1 commit into from
Nov 11, 2020

Conversation

johngmyers
Copy link
Member

Validating components is redundant with the masterStaticPods check.

Fixes #10057

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 11, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 11, 2020
@hakman
Copy link
Member

hakman commented Nov 11, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 4174b0f into kubernetes:master Nov 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 11, 2020
k8s-ci-robot added a commit that referenced this pull request Nov 11, 2020
…-upstream-release-1.19

Automated cherry pick of #10214: Remove components from cluster validation
@johngmyers johngmyers deleted the remove-component branch November 11, 2020 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ComponentStatus API is being deprecated
4 participants