Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't install the misc packages for k8s 1.20+ #10222

Merged
merged 2 commits into from
Nov 14, 2020
Merged

Don't install the misc packages for k8s 1.20+ #10222

merged 2 commits into from
Nov 14, 2020

Conversation

johngmyers
Copy link
Member

I intend to make the boundary be 1.20, but the e2e tests are currently configured with 1.19.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 11, 2020
@johngmyers
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2020
@johngmyers johngmyers force-pushed the prune-misc branch 2 times, most recently from 54c1a69 to 7b13b19 Compare November 13, 2020 05:42
@johngmyers johngmyers changed the title WIP: Don't install the misc packages for k8s 1.19+ Don't install the misc packages for k8s 1.20+ Nov 13, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2020
@johngmyers
Copy link
Member Author

/retest

hakman
hakman reviewed Nov 13, 2020
View reviewed changes
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intend to make the boundary be 1.20, but the e2e tests are currently configured with 1.19.

Any special reason not to start with 1.19?

I would move the "nfs-*" packages to packages.go and skip miscutils.go completely.

@johngmyers
Copy link
Member Author

It didn't seem that the benefit from this merited backporting to the 1.19 branch.

@hakman
Copy link
Member

hakman commented Nov 14, 2020

Sounds good to me. Thanks.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit de65803 into kubernetes:master Nov 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 14, 2020
@johngmyers johngmyers deleted the prune-misc branch November 14, 2020 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman left review comments

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johngmyers @k8s-ci-robot @hakman