Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kops as kOps and remove extra spaces from .md files #10235

Merged
merged 4 commits into from
Nov 14, 2020

Conversation

axpraka
Copy link
Contributor

@axpraka axpraka commented Nov 14, 2020

Minor updates in documentation. Below are two changes which I am suggesting in few .md files.

  • Updated kops as kOps in .md files.
  • Remove extra spaces from .md files

- Updated kops as kOps in .md files.
- Remove extra spaces from .md files
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Nov 14, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @axpraka!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @axpraka. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 14, 2020
@k8s-ci-robot k8s-ci-robot added area/documentation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2020
@axpraka
Copy link
Contributor Author

axpraka commented Nov 14, 2020

I signed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Nov 14, 2020
@axpraka
Copy link
Contributor Author

axpraka commented Nov 14, 2020

/assign @zetaab

@hakman
Copy link
Member

hakman commented Nov 14, 2020

Very nice update! Thanks for fixing all these.
The docs/cli files are generated from cmd/kops. Please update those also to pass the tests.
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2020
Updated kops as kOps for document.
@axpraka
Copy link
Contributor Author

axpraka commented Nov 14, 2020

/make gen-cli-docs

@hakman
Copy link
Member

hakman commented Nov 14, 2020

Do you need help, @axpraka ?

@axpraka
Copy link
Contributor Author

axpraka commented Nov 14, 2020

@hakman - yes. Can you tell me why it is failing at CI/verify? Is this because of file conflict?

Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have to run make gen-cli-docs and commit the changes, or check the log file and see what changes differ between the .go files and the .md files.

cmd/kops/root.go Outdated Show resolved Hide resolved
cmd/kops/root.go Outdated Show resolved Hide resolved
axpraka and others added 2 commits November 14, 2020 08:24
Co-authored-by: Ciprian Hacman <ciprianhacman@gmail.com>
@hakman
Copy link
Member

hakman commented Nov 14, 2020

I regenerated the CLI docs and the tests should pass now. Could you take one last look to see if it looks right?
A preview of the changes should be available here: https://5fafe4e0236b120007071fe6--kubernetes-kops.netlify.app.

@axpraka
Copy link
Contributor Author

axpraka commented Nov 14, 2020

@hakman thanks for helping with conflicts. I checked and it looks fine now.

@hakman
Copy link
Member

hakman commented Nov 14, 2020

Great! Thanks for checking.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axpraka, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 14, 2020
@k8s-ci-robot k8s-ci-robot merged commit 9e14b29 into kubernetes:master Nov 14, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 14, 2020
@axpraka axpraka deleted the update-kops-as-kOps branch November 14, 2020 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants