Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Associate instance group to pod validation failures in cluster validation. #10237

Merged
merged 3 commits into from
Nov 15, 2020
Merged

Associate instance group to pod validation failures in cluster validation. #10237

merged 3 commits into from
Nov 15, 2020

Conversation

bharath-123
Copy link
Contributor

@bharath-123 bharath-123 commented Nov 14, 2020 •
edited
Loading

This PR fixes #10183

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 14, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bharath-123. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/rolling-update labels Nov 14, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 14, 2020
@bharath-123
Copy link
Contributor Author

/ok-to-test

@k8s-ci-robot
Copy link
Contributor

@bharath-123: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@bharath-123
Copy link
Contributor Author

/cc @johngmyers

@johngmyers
Copy link
Member

I believe that failures of pods of priorityClass "system-cluster-critical" are cluster-wide, so should not be marked as specific to their pod's instanceGroup.

Failures of pods of priorityClass "system-node-critical" are specific to the node, so should be marked as specific to their pods instanceGroup.

@johngmyers
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 14, 2020
@bharath-123
Copy link
Contributor Author

Yes your right. Will take care of this. Thanks for pointing this out!

@bharath-123
validate_cluster: Create node to instance group mapping to get pod in…
5c9b688 
…stance group

In the ValidationError struct, there is a field to identify the instance group to
which the ValidationError is associated with.

For pod related ValidationErrors, it is not straightforward to identify the
instance group to which the pod is associated with.

To acheive this, we create a node to instance group mapping in ValidateNodes.
This node to instance group mapping is used in collectPodFailures to identify the
pod instance group by using the pod's hostIp field.

We don't associate system-cluster-critical pods to instance groups as those pod
failures are cluster wide
@bharath-123
validate_cluster_test: enhance validatePodFailure tests
424ab37 
We are now able to identify the instance group associated with a pod.

Add an extra layer to the validatePodFailure to the test where we
create a mock InstanceGroup and associate the pod failures with the
instance group to which the pod belongs to.
@bharath-123
instancegroups: Clear out the TODO comment
208199b 
Now that we are  able to associate pod validation failures with the
instance groups. We can remove the TODO comment
@bharath-123 bharath-123 force-pushed the feature/pod-instance-group-mapping branch from e9cf06d to 208199b Compare November 15, 2020 05:45
@bharath-123
Copy link
Contributor Author

/retest

@johngmyers
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-123, johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1bf5205 into kubernetes:master Nov 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjtempleton gjtempleton Awaiting requested review from gjtempleton

@joshbranham joshbranham Awaiting requested review from joshbranham

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@johngmyers johngmyers

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/rolling-update cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Identify associated instance group for all validation error during cluster validation
3 participants
@bharath-123 @k8s-ci-robot @johngmyers