Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate domain for kops-controller bootstrap #10239

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Use separate domain for kops-controller bootstrap #10239

merged 1 commit into from
Nov 18, 2020

Conversation

johngmyers
Copy link
Member

Fixes #10139

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 14, 2020
@johngmyers johngmyers mentioned this pull request Nov 14, 2020
Closed
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 14, 2020
@johngmyers johngmyers changed the title WIP: Use separate domain for kops-controller bootstrap Use separate domain for kops-controller bootstrap Nov 14, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 14, 2020
@hakman
Copy link
Member

hakman commented Nov 18, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2020
@k8s-ci-robot k8s-ci-robot merged commit 454ffdd into kubernetes:master Nov 18, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 18, 2020
@johngmyers johngmyers deleted the kops-controller-domain branch November 18, 2020 08:21
@johngmyers johngmyers mentioned this pull request Nov 18, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Nov 18, 2020
@k8s-ci-robot
Merge pull request #10260 from johngmyers/automated-cherry-pick-of-#1…
92102b0 
…0239-upstream-release-1.19

Automated cherry pick of #10239: Use separate domain for kops-controller bootstrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesplain mikesplain Awaiting requested review from mikesplain

@zetaab zetaab Awaiting requested review from zetaab

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
3 participants
@johngmyers @k8s-ci-robot @hakman