Fix cloudformation lint job #10256
Merged
Fix cloudformation lint job #10256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
/test pull-kops-verify-cloudformation |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
The dockerfile we were using in the cfn-python-lint repo wasn't actually pinned to the version associated with the git tag, it always installs the latest version. A recent release consolidated error rules regarding invalid values. We use an invalid "us-test-1" region and zones in much of our testing. We used to be able to ignore this "invalid AZ" error, but now we would need to ignore all invalid values for all resource properties. This pins cfn-python-lint to an older version but we'll have to figure out how we want to handle this longer term.
rifelpet
force-pushed
the
cfn-python-lint
branch
from
0f9ce1a
to
df1e301
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Dockerfile we were using in the cfn-python-lint repo wasn't actually pinned to the version associated with the git tag, it always installs the latest version.
A recent release consolidated error rules regarding invalid values (aws-cloudformation/cfn-lint#1750)
We use an intentionally invalid "us-test-1" region and zones in much of our testing. We used to be able to ignore this "invalid AZ" error (E2510), but now we would need to ignore all invalid values for all resource properties.
This pins cfn-python-lint to an older version by providing our own Dockerfile, but we'll have to figure out how we want to handle this longer term.
Fixes https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kops/9666/pull-kops-verify-cloudformation/1328738395379208192