Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recognize ubuntu 20.10 #10278

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Recognize ubuntu 20.10 #10278

merged 1 commit into from
Jan 5, 2021

Conversation

justinsb
Copy link
Member

Teach nodeup about ubuntu 20.10, including the unusual
/etc/resolv.conf configuration.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/nodeup approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 20, 2020
@justinsb
Copy link
Member Author

I'm actually not sure if we want to recognize / support non-LTS ubuntu versions. It's pretty low-effort now that we're installing docker / containerd from tar.gz packages.

@justinsb
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 20, 2020
@hakman
Copy link
Member

hakman commented Nov 20, 2020

I'm actually not sure if we want to recognize / support non-LTS ubuntu versions. It's pretty low-effort now that we're installing docker / containerd from tar.gz packages.

As long as we agree that we will treat these non-LTS as LATEST and always replace it when a new one is released, should be fine.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 20, 2020
johngmyers
johngmyers reviewed Nov 21, 2020
View reviewed changes
nodeup/pkg/model/miscutils.go
packages = append(packages, "apt-transport-https")

// TODO: Do we really need python-apt?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt we need any of these, which is why I'm phasing them out for k8s 1.20+

@justinsb
Copy link
Member Author

justinsb commented Dec 4, 2020

As long as we agree that we will treat these non-LTS as LATEST and always replace it when a new one is released, should be fine.

I'm going to put this on the agenda for today. OTOH I agree that otherwise it could become a lot of work, OTOH we don't really want a kops upgrade to break people's working configurations.

What motivated this was that the latest ubuntu image on GCP is not LTS (the LTS is also available, it just wasn't the first that caught my eye). So it was a little annoying to have the cluster fail to start there.

@justinsb
Recognize ubuntu 20.10
b17e44b 
Teach nodeup about ubuntu 20.10, including the unusual
/etc/resolv.conf configuration.
@justinsb
Copy link
Member Author

justinsb commented Jan 5, 2021

/hold cancel

As we discussed in the meeting today, this proves important for cri-o support. The plan is not to advertise that non-LTS ubuntu works, but it can be handy to keep up with upstream ubuntu changes.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2021
@hakman
Copy link
Member

hakman commented Jan 5, 2021

Cool! :)
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit df13837 into kubernetes:master Jan 5, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Jan 5, 2021
@moshevayner
Copy link
Member

@hakman Does this mean we can start updating the ami with 20.10 versions on a more frequent basis from now on?

@olemarkus
Copy link
Member

@MoShitrit If you refer to the channels, they should remain with the LTS versions.

@moshevayner
Copy link
Member

Thanks for clarifying @olemarkus !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers johngmyers left review comments

@hakman hakman hakman left review comments

@joshbranham joshbranham Awaiting requested review from joshbranham

@rdrgmnzs rdrgmnzs Awaiting requested review from rdrgmnzs

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/nodeup cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@justinsb @k8s-ci-robot @hakman @moshevayner @olemarkus @johngmyers