Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can check cert expiry using openssl #10282

Merged
merged 2 commits into from
Nov 22, 2020
Merged

Can check cert expiry using openssl #10282

merged 2 commits into from
Nov 22, 2020

Conversation

alok87
Copy link
Contributor

@alok87 alok87 commented Nov 20, 2020 •
edited
Loading

Can check cert expiry using openssl

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 20, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @alok87. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. area/documentation labels Nov 20, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 20, 2020
@alok87 alok87 force-pushed the doc-update-cert-expiry-trick3 branch from 034dcec to 327ed4e Compare November 20, 2020 19:56
@alok87
Copy link
Contributor Author

alok87 commented Nov 21, 2020

/assign @hakman

@johngmyers
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2020
@johngmyers
Copy link
Member

Thanks!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alok87, johngmyers

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 21, 2020
@hakman
Copy link
Member

hakman commented Nov 21, 2020

/hold for clarifications

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Nov 21, 2020
@alok87 alok87 force-pushed the doc-update-cert-expiry-trick3 branch from 7b958eb to 3b2c231 Compare November 22, 2020 01:28
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 22, 2020
@alok87 alok87 changed the title Trick3 for recovering when certificate has expired and k8s api is down Can check cert expiry using openssl Nov 22, 2020
@alok87
Copy link
Contributor Author

alok87 commented Nov 22, 2020

/assign @hakman

@hakman hakman added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 22, 2020
@hakman hakman force-pushed the doc-update-cert-expiry-trick3 branch from 3c99033 to d44650c Compare November 22, 2020 05:55
@hakman hakman force-pushed the doc-update-cert-expiry-trick3 branch from d44650c to 608be53 Compare November 22, 2020 05:56
@hakman
Copy link
Member

hakman commented Nov 22, 2020

/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 22, 2020
@hakman hakman removed the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3d1038b into kubernetes:master Nov 22, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakman hakman hakman requested changes

@johngmyers johngmyers johngmyers requested changes

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@johngmyers johngmyers

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alok87 @k8s-ci-robot @johngmyers @hakman