Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #10273: Add support for default version override #10302

Conversation

hakman
Copy link
Member

@hakman hakman commented Nov 23, 2020

Cherry pick of #10273 on release-1.18.

#10273: Add support for default version override

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Nov 23, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 23, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/addons area/api approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation labels Nov 23, 2020
@hakman hakman force-pushed the automated-cherry-pick-of-#10273-upstream-release-1.18 branch from e03225a to 19bc1b5 Compare November 23, 2020 04:20
dntosas and others added 2 commits November 23, 2020 06:23
In this commit, we enable users to override default version
of networking/Weave specs.

Signed-off-by: dntosas <ntosas@gmail.com>
@hakman hakman force-pushed the automated-cherry-pick-of-#10273-upstream-release-1.18 branch from 19bc1b5 to 0a8905f Compare November 23, 2020 04:23
@rdrgmnzs
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 3937c06 into kubernetes:release-1.18 Nov 23, 2020
@hakman hakman deleted the automated-cherry-pick-of-#10273-upstream-release-1.18 branch December 12, 2020 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants