Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimal cert-manager addon #10318

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

olemarkus
Copy link
Member

There are several images involved here, so dropped the usual Image field until we have a better understanding how to handle this. Making at minimum the version configurable can be done well in time for 1.20 alpha anyway.

Adding this PR is a prereq for some other addons + the kops-controller issuer.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 26, 2020
@k8s-ci-robot k8s-ci-robot added area/addons size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/api area/documentation labels Nov 26, 2020
@hakman
Copy link
Member

hakman commented Nov 26, 2020

I am a bit concerned about the 1.6 MB template that is being pulled into bindata.go also.

@olemarkus
Copy link
Member Author

Pretty huge CRDs. But can we do much about that?

@hakman
Copy link
Member

hakman commented Nov 26, 2020

Not sure what can be done about it, but probably something should be done.

@olemarkus
Copy link
Member Author

cert-manager/cert-manager#3299

They are what they are. I can't think of a reason this would cause any harm.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 3, 2020
@k8s-ci-robot k8s-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. do-not-merge/contains-merge-commits labels Dec 4, 2020
Copy link
Member

@hakman hakman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few Q:

  1. Why switch from the cert-manager namespace to kube-system?
  2. Why limit running on master nodes?

upup/pkg/fi/cloudup/bootstrapchannelbuilder.go Outdated Show resolved Hide resolved
Co-authored-by: Ciprian Hacman <ciprianhacman@gmail.com>
@olemarkus
Copy link
Member Author

Why switch from the cert-manager namespace to kube-system?

Kops could technically have its own namespace for addons that doesn't strictly need to be in kube-system. But we don't have anything like this. So when it comes to PSPs and such, we don't have much choice but to deploy it to kube-system.

Why limit running on master nodes?

A lot of users run cert-manager on masters to leverage DNS ACME authentication. If/when we get IRSA more mature (and if this doesn't end up in a circular dependency) it could run on normal nodes using a dedicated IAM role.

@hakman
Copy link
Member

hakman commented Dec 5, 2020

Thanks for the explanation.
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, olemarkus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2020
@k8s-ci-robot k8s-ci-robot merged commit 7140d96 into kubernetes:master Dec 5, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addons area/api area/documentation cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants