Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for CentOS 8 #10368

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 5, 2020

Fixes: #10327

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 5, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2020

```bash
aws ec2 describe-images --region us-east-1 --output table \
--owners 679593333241 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is the account ID that is kops' WellKnownAccountCentOS but the account ID in the CentOS wiki is different: https://wiki.centos.org/Cloud/AWS It would be nice to figure out why they're different and if we should switch to the one mentioned upstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the AWS Marketplace account. Changed it a bit and now references the AWS Provided Marketplace Images with Updates:
https://wiki.centos.org/Cloud/AWS#AWS_Provided_Marketplace_Images_with_Updates

We could move to their new owner ID and images, but don't know if there's a lot of value and we would have to change the WellKnownAccountCentOS also.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thought about it a bit more and just changed it to the new CentOS repo. Easier to understand for anyone and probably will get the latest updates.

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Dec 9, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2020
@hakman hakman removed the blocks-next label Dec 9, 2020
@k8s-ci-robot k8s-ci-robot merged commit 4d9239c into kubernetes:master Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 9, 2020
@hakman hakman deleted the docs-centos-8 branch January 10, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CentOS 8: as base dist
4 participants