Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to reuse existing Elastic IPs for NAT gateways #10374

Merged
merged 1 commit into from
Dec 6, 2020
Merged

Add option to reuse existing Elastic IPs for NAT gateways #10374

merged 1 commit into from
Dec 6, 2020

Conversation

hakman
Copy link
Member

@hakman hakman commented Dec 6, 2020

Fixes: #3182

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/api area/documentation approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 6, 2020
@hakman hakman changed the title Add option to reuse existing elastic IPs for NAT gateways Add option to reuse existing Elastic IPs for NAT gateways Dec 6, 2020
@olemarkus
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 6, 2020
@k8s-ci-robot k8s-ci-robot merged commit e68a464 into kubernetes:master Dec 6, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 6, 2020
@hakman
Copy link
Member Author

hakman commented Dec 6, 2020

Thanks @olemarkus

@hakman hakman deleted the eip-egress branch December 6, 2020 13:38
@hakman hakman mentioned this pull request Dec 6, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Dec 8, 2020
@k8s-ci-robot
Merge pull request #10376 from hakman/automated-cherry-pick-of-#10374…
90a8883 
…-upstream-release-1.19

Automated cherry pick of #10374: Add option to reuse existing Elastic IPs for NAT gateways
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbranham joshbranham Awaiting requested review from joshbranham

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

Assignees

@olemarkus olemarkus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

Re-using existing elastic IPs for NAT gateways created by kops
3 participants
@hakman @k8s-ci-robot @olemarkus