Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly specify http_endpoint in terraform launch template #10398

Merged
merged 1 commit into from
Dec 9, 2020
Merged

Explicitly specify http_endpoint in terraform launch template #10398

merged 1 commit into from
Dec 9, 2020

Conversation

bharath-123
Copy link
Contributor

Terraform launch templates require http_endpoint to be explicitly set to "enabled" or "disabled" according to hashicorp/terraform-provider-aws#12564.

Fixes #10393

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @bharath-123. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Dec 9, 2020
seh
seh reviewed Dec 9, 2020
View reviewed changes
Copy link
Contributor

@seh seh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fast turnaround.

upup/pkg/fi/cloudup/awstasks/launchtemplate_target_terraform.go Outdated Show resolved Hide resolved
upup/pkg/fi/cloudup/awstasks/launchtemplate_target_terraform.go Outdated Show resolved Hide resolved
hakman
hakman reviewed Dec 9, 2020
View reviewed changes
docs/instance_groups.md Outdated Show resolved Hide resolved
@bharath-123
Copy link
Contributor Author

will rebase and push.

@hakman
Copy link
Member

hakman commented Dec 9, 2020

Please add this last change and squash all commits into one.
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2020
@bharath-123
Copy link
Contributor Author

Please add this last change and squash all commits into one.
/ok-to-test

I ll keep the docs in a seperate commit @hakman ?

@bharath-123 bharath-123 force-pushed the fix/imdv2-terraform branch 2 times, most recently from eff5083 to dc3a709 Compare December 9, 2020 19:58
@bharath-123
Copy link
Contributor Author

@bharath-123: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-verify-gofmt eff5083 link /test pull-kops-verify-gofmt
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

@bharath-123 bharath-123 closed this Dec 9, 2020
@bharath-123 bharath-123 reopened this Dec 9, 2020
@bharath-123
Copy link
Contributor Author

wrong button oops

@bharath-123
Explicitly specify http_endpoint in launch_template terraform
cebe171 
http_endpoint has to be explicitly specified in the metadata_options block
of the launch template terraform according to issue
hashicorp/terraform-provider-aws#12564
@hakman
Copy link
Member

hakman commented Dec 9, 2020

Thanks @bharath-123 :).
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bharath-123, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2020
@hakman hakman mentioned this pull request Dec 9, 2020
Merged
@k8s-ci-robot k8s-ci-robot merged commit 60a6784 into kubernetes:master Dec 9, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 9, 2020
k8s-ci-robot added a commit that referenced this pull request Dec 10, 2020
@k8s-ci-robot
Merge pull request #10399 from hakman/automated-cherry-pick-of-#10398…
d35eb52 
…-upstream-release-1.19

Automated cherry pick of #10398: Explicitly specify http_endpoint in launch_template terraform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seh seh seh left review comments

@hakman hakman hakman left review comments

@KashifSaadat KashifSaadat Awaiting requested review from KashifSaadat

Assignees

@hakman hakman

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

AWS launch template metadata options lacking "http_endpoint" attribute fails with Terraform
4 participants
@bharath-123 @k8s-ci-robot @hakman @seh