Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack script improvements #10407

Merged
merged 4 commits into from
Dec 11, 2020
Merged

Hack script improvements #10407

merged 4 commits into from
Dec 11, 2020

Conversation

rifelpet
Copy link
Member

Previously we were tracking a list of kops packages in hack/.packages for use by the goimports python scripts. This replaces them with shell scripts (to match all of the other hack scripts) and uses lists of go files rather than packages, removing the need for .packages and all of its dependent python code. The goimports scripts no longer rely on GOPATH.

We'll need to remove the verify-packages prow job before this merges. I will open a test-infra PR to remove verify-packages once the other jobs for this PR pass.

This also updates the apimachinery binaries to be compiled to _output/bin via the hack go submodule to match other development tools. This is the last dependency on GOPATH, because the gengo library that apimachinery uses assumes that the package name that we specify for generated files will be located at $GOPATH/src/$PACKAGE. See the issue mentioned in Makefile for more info.

Lastly this has the pki unit tests ignore KOPS_RSA_PRIVATE_KEY_SIZE. This way we can have the env var set in our terminal to make the integration tests faster while not affecting the pki unit tests.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 11, 2020
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 11, 2020

@rifelpet: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kops-verify-packages 4fc2939 link /test pull-kops-verify-packages

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hakman
Copy link
Member

hakman commented Dec 11, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit dfa68a0 into kubernetes:master Dec 11, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 11, 2020
@hakman hakman mentioned this pull request Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants