Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotinst: Support for multiple subnets per zone #10452

Merged
merged 1 commit into from
Dec 19, 2020

Conversation

liranp
Copy link
Contributor

@liranp liranp commented Dec 17, 2020

This PR adds support for multiple subnets per zone by configuring subnets without specifying zone names (according to the Spot API specification).

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liranp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/provider/spotinst Issues or PRs related to spotinst provider approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2020
@hakman
Copy link
Member

hakman commented Dec 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit e747047 into kubernetes:master Dec 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 19, 2020
@liranp liranp deleted the feat-elastigroup-subnets branch April 6, 2021 18:22
@vmasule
Copy link

vmasule commented Jun 18, 2021

@here Is there documentation for this, I have a scenario where multiple private subnets should be created in one AZ. Current I can't understand how that can be achieved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants