Add gp3 Volume Type to etcd

[msidwell]

Fixes #10438

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @msidwell!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @msidwell. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hakman]

@msidwell This looks quite nice. Should be a good improvement to volumes.
Can you check for VolumeTypeIo1 in code? I think you need to add references to io2 and gp3 also in those locations.
Because you added a new field, you will also have to run make apimachinery to generate some files.

[msidwell]

it looks like the upstream auto scaling group sdk Ebs struct doesn't handle a throughput parameter, so I left that alone for now

[olemarkus]

This looks good.

In your original post, you can write:
Fixes #10438

That will make github autoclose that issue once this PR merges

[rifelpet]

/ok-to-test

[hakman]

/retest

[hakman]

it looks like the upstream auto scaling group sdk Ebs struct doesn't handle a throughput parameter, so I left that alone for now

OK, let's concentrate on the etcd part. Could you remove the code that is not required for this purpose and squash the commits?

[msidwell]

removed unnecessary changes beyond core etcd functionality and squashed to one commit

[hakman]

Perfect. Thanks @msidwell!
@olemarkus what do you think, should we add this to 1.19 to let people try it and see if it would be a good default for 1.20?
/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hakman, msidwell

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olemarkus]

Yeah let's. This is consistent with control plane volumes, isn't it?

[hakman]

Yeah let's. This is consistent with control plane volumes, isn't it?

There is no possibility to set throughput for control plane volumes at the moment. This would allow setting the throughput only for etcd volumes.

[hakman]

/retest

[olemarkus]

That bit is indeed missing. Was more thinking of adding gp3 support and eventually defaulting to

[hakman]

Should be possible to add to launch templates also easily, but probably in the .1 release.