Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace (some) deprecated ResourceHolder with Resource #10472

Merged
merged 2 commits into from Dec 19, 2020

Conversation

justinsb
Copy link
Member

This removes more of the deprecated type, but it also simplifies
refactoring the GCE InstanceTemplate.

This removes more of the deprecated type, but it also simplifies
refactoring the GCE InstanceTemplate.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the area/provider/alicloud Issues or PRs related to alicloud provider label Dec 19, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/openstack Issues or PRs related to openstack provider area/provider/spotinst Issues or PRs related to spotinst provider size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2020
@hakman
Copy link
Member

hakman commented Dec 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 19, 2020
@hakman hakman closed this Dec 19, 2020
@hakman hakman reopened this Dec 19, 2020
@hakman
Copy link
Member

hakman commented Dec 19, 2020

Something is not working right here with the Prow tests. Even the CLA check is not reporting the status.

@k8s-ci-robot k8s-ci-robot merged commit 652e78f into kubernetes:master Dec 19, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 19, 2020
@rifelpet rifelpet mentioned this pull request Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/alicloud Issues or PRs related to alicloud provider area/provider/aws Issues or PRs related to aws provider area/provider/digitalocean Issues or PRs related to digitalocean provider area/provider/openstack Issues or PRs related to openstack provider area/provider/spotinst Issues or PRs related to spotinst provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants