Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor nodeUpConfigBuilder to be standalone #10476

Merged

Conversation

justinsb
Copy link
Member

We break the hard-link with the ApplyClusterCmd, the code is
over-coupled and ApplyClusterCmd is too big.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 19, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justinsb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2020
@hakman
Copy link
Member

hakman commented Dec 20, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2020
@hakman
Copy link
Member

hakman commented Dec 20, 2020

/retest

@hakman hakman force-pushed the refactor_bootstrap_script_build branch from cfb5778 to fe148d4 Compare December 20, 2020 07:31
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2020
We break the hard-link with the ApplyClusterCmd, the code is
over-coupled and ApplyClusterCmd is too big.
@hakman hakman force-pushed the refactor_bootstrap_script_build branch from fe148d4 to 6de9994 Compare December 20, 2020 07:33
@hakman
Copy link
Member

hakman commented Dec 20, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2020
@k8s-ci-robot k8s-ci-robot merged commit 591dffa into kubernetes:master Dec 20, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants