Added event-qps and event-burst flags to kubelet

[DOboznyi]

#6356 Enable kubelet --event-qps flag.
#6150 Will provide the functionality to fix [WARN] 4.2.9 Ensure that the --event-qps argument is set to 0 or a level which ensures appropriate event capture (Not Scored) in kube-bench report (CIS benchmarks)

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @DOboznyi!

It looks like this is your first PR to kubernetes/kops 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kops has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @DOboznyi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[olemarkus]

Thanks for this.
Wondering if the best practice is to set this to 0, then shouldn't we default it to zero? Defaulting it to omitted, which will explicitly make the test fail, doesn't seem appropriate at least.

[DOboznyi]

Thanks for this.
Wondering if the best practice is to set this to 0, then shouldn't we default it to zero? Defaulting it to omitted, which will explicitly make the test fail, doesn't seem appropriate at least.

Maybe better to set it to 5. Because 0 can provide a security issue from my perspective. It will make it unlimited.

[olemarkus]

I think the CIS check is there because if you rate limit, important events can be missed. Thus the

[WARN] 4.2.9 Ensure that the --event-qps argument is set to 0 or a level which ensures appropriate event capture (Not Scored)

Setting it to 5 will retain current behaviour, which is also fine.

[DOboznyi]

@olemarkus, you are completely right. Where could i add default value as 0? I'm not familiar with kops code base.

[DOboznyi]

@olemarkus I changed default value to 0. Could you review PR again?

[hakman]

/ok-to-test

[hakman]

Thanks @DOboznyi. Looks good from my point of view. @olemarkus any thoughts before merging?
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DOboznyi, hakman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hakman]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[hakman]

One more thing @DOboznyi, could you squash the commits?

[DOboznyi]

@hakman done, all commits squashed.

[DOboznyi]

@hakman do you have any ideas why test failed?

[DOboznyi]

/retest

[hakman]

@hakman do you have any ideas why test failed?

Flake, no worries. :)

[DOboznyi]

@hakman do you have any ideas why test failed?

Flake, no worries. :)

From the second attempt test passed. Is it ready to merge now?

[olemarkus]

/lgtm