AWS IAM Role Tagging #10488
Merged
AWS IAM Role Tagging #10488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/provider/aws
rifelpet
force-pushed
the
iam-role-tag
branch
from
5f1300d
to
5406744
Compare
k8s-ci-robot
removed
the
needs-rebase
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #9640
This adds support for tagging IAM roles with the usual cloud tags, as demonstrated by the updated integration test outputs.
An idea I had for this was to add tags for service account roles that specify the service account name and namespace but we need to decide on the tag keys to use. I'm not aware of any official recommendations for this but we could do something similar to what the aws-load-balancer-controller does for ingress tags:
https://github.com/kubernetes-sigs/aws-load-balancer-controller/blob/9776d298fddc1bb7fe9245510467d2507580ec96/internal/alb/generator/tag.go#L14
kubernetes.io/namespacekubernetes.io/service-account-nameI'd like to ensure that would be acceptable first given the reserved nature of
kubernetes.io. Any ideas @justinsb?