Add AWS LoadBalancerController #10489
Conversation
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
area/addons
area/api
size/XXL
k8s-ci-robot
added
the
needs-rebase
olemarkus
force-pushed
the
aws-loadbalancer-controller
branch
from
c31e9e7
to
46cb8a4
Compare
k8s-ci-robot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: olemarkus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
olemarkus
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
olemarkus
force-pushed
the
aws-loadbalancer-controller
branch
from
46cb8a4
to
01b3053
Compare
|
/milestone v1.20 |
...ls/cloudup/resources/addons/aws-load-balancer-controller.addons.k8s.io/k8s-1.9.yaml.template
Show resolved
Hide resolved
upup/models/bindata.go
Outdated
| limits: | ||
| cpu: 200m | ||
| memory: 500Mi |
There was a problem hiding this comment.
maybe we should remove limits in here as well? ^^
for bigger clusters LB controller may need some more memory during reconciliation, we should avoid OOMkills (happened to us a lot of times)
There was a problem hiding this comment.
ofc we can see this in next PRs, just mentioning it not to forget
There was a problem hiding this comment.
Thanks. No I agree not putting limits on this one. Removed.
upup/models/bindata.go
Outdated
| - --enable-waf=false | ||
| - --enable-wafv2=false | ||
| - --enable-shield=false |
There was a problem hiding this comment.
should these ones be configurable? if you agree, i can take it on next PR
There was a problem hiding this comment.
Not right now. We should at least wait for IRSA support.
The idea that anything running on the control plane can disable waf or shield on any AWS ELB (even those not owned by the cluster) sounds a bit too insane to me.
olemarkus
force-pushed
the
aws-loadbalancer-controller
branch
from
01b3053
to
1befaf3
Compare
...ls/cloudup/resources/addons/aws-load-balancer-controller.addons.k8s.io/k8s-1.9.yaml.template
Show resolved
Hide resolved
pkg/apis/kops/componentconfig.go
Outdated
| // Default: false | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
| // Image is the docker container used. | ||
| // Default: v2.0.0 |
There was a problem hiding this comment.
Not sure if this is a good place to mention default by version.
...ls/cloudup/resources/addons/aws-load-balancer-controller.addons.k8s.io/k8s-1.9.yaml.template
Outdated
Show resolved
Hide resolved
upup/pkg/fi/cloudup/bootstrapchannelbuilder/bootstrapchannelbuilder.go
Outdated
Show resolved
Hide resolved
olemarkus
force-pushed
the
aws-loadbalancer-controller
branch
from
e23ad9b
to
943cd9a
Compare
| // Enabled enables the loadbalancer controller. | ||
| // Default: false | ||
| Enabled *bool `json:"enabled,omitempty"` | ||
| // Image is the docker container used. |
There was a problem hiding this comment.
| // Image is the docker container used. | |
| // Image is the container image tag used. |
Co-authored-by: Ciprian Hacman <ciprianhacman@gmail.com>
olemarkus
force-pushed
the
aws-loadbalancer-controller
branch
from
943cd9a
to
e106e5f
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
…489-origin-release-1.20 Automated cherry pick of #10489: Add AWS LoadBalancerController
Also waiting for #10149
Should otherwise be good.