Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat InvalidDhcpOptionsId.NotFound as already-deleted #10508

Merged
merged 1 commit into from
Dec 30, 2020
Merged

Treat InvalidDhcpOptionsId.NotFound as already-deleted #10508

merged 1 commit into from
Dec 30, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Dec 28, 2020

In case DeleteDhcpOptions returns InvalidDhcpOptionsId.NotFound, if somehow the dhcpoptions is deleted between "list resource" and "delete", treat it as successful delete.

To avoid this:

I1228 20:39:50.478507 28 errors.go:32] unexpected aws error code: "InvalidDhcpOptionsID.NotFound"
dhcp-options:dopt-09a83785234855c50 error deleting resources, will retry: error deleting DhcpOptions "dopt-09a83785234855c50": InvalidDhcpOptionsID.NotFound: The dhcpOptions ID 'dopt-09a83785234855c50' does not exist
...
not making progress deleting resources; giving up

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 28, 2020
@k8s-ci-robot k8s-ci-robot added area/provider/aws Issues or PRs related to aws provider size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 28, 2020
@rifelpet
Copy link
Member

thanks!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rifelpet, wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2020
@k8s-ci-robot k8s-ci-robot merged commit 0e34ce1 into kubernetes:master Dec 30, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.20 milestone Dec 30, 2020
@hakman hakman mentioned this pull request Dec 30, 2020
Merged
k8s-ci-robot added a commit that referenced this pull request Jan 5, 2021
@k8s-ci-robot
Merge pull request #10511 from hakman/automated-cherry-pick-of-#10508…
dee8dd1 
…-upstream-release-1.19

Automated cherry pick of #10508: Treat InvalidDhcpOptionsId.NotFound as already-deleted
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@mikesplain mikesplain Awaiting requested review from mikesplain

Assignees

@rifelpet rifelpet

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/aws Issues or PRs related to aws provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wongma7 @rifelpet @k8s-ci-robot